Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inter to latest version #3429

Closed
SimonVillage opened this issue May 19, 2021 · 36 comments · Fixed by #7776
Closed

Update Inter to latest version #3429

SimonVillage opened this issue May 19, 2021 · 36 comments · Fixed by #7776
Assignees
Labels
-- Regressions Shows diff with previous published version I Font Upgrade P3
Milestone

Comments

@SimonVillage
Copy link

It seems like that the version used by google fonts is an outdated version. There is no support for some of the symbols as example the Baht (THB ฿) sign

https://fonts.google.com/specimen/Inter?query=inter&preview.text=%E0%B8%BF1,047&preview.text_type=custom

However, it seems to be implemented in a newer version of the font:

https://rsms.me/inter/glyphs/?g=baht

@thundernixon I have seen that you created the PR #1908 for inter, maybe you would be able to make a PR for a newer version?

@RosaWagner
Copy link
Contributor

As per request in #2386 (comment), we would like to upgrade Inter in Google Fonts. Although last release is version 3.19, and GF is serving that version. I also saw some activities in the upstream repo from 1 week ago.

@rsms Is there a stable version we could onboard, and can you cut a release with it?

Reported issues in google/fonts to track:
https://github.com/google/fonts/issues?q=is%3Aissue+is%3Aopen+inter+label%3Az_Inter

@RosaWagner RosaWagner added this to the 2022 Q2 milestone Apr 29, 2022
@RosaWagner RosaWagner self-assigned this Apr 29, 2022
@RosaWagner RosaWagner modified the milestones: 2022 Q2, 2022 Q3 Jul 1, 2022
@RosaWagner RosaWagner modified the milestones: 2022 Q3, 2022 Q4 Jul 30, 2022
@applecuckoo
Copy link
Contributor

applecuckoo commented Sep 16, 2022

Hey @RosaWagner it seems that @rsms is in the middle of adding an optical size axis, maybe upgrade to 'Expand Styles'? See rsms/inter#463 (comment) for more info.

EDIT 19/09/22: Oh, and the Google Fonts version is missing italics.

@applecuckoo
Copy link
Contributor

CC @emmamarichal

@applecuckoo
Copy link
Contributor

This discussion comment rsms/inter#463 (reply in thread) shows that optical sizing is still in the works, maybe we should just get 3.19 on for now and once the optical size axis is sorted we can onboard that update. What do you think?

@applecuckoo
Copy link
Contributor

@RosaWagner I got a reply from @rsms today on the beta testing thread, rsms/inter#463 (reply in thread). He says that now's a good time to onboard 3.19 since v4 is coming later:

@applecuckoo Onboarding 3.19 now sounds like a good idea.
Version 4 is at least a month or so away from being ready.

@RosaWagner RosaWagner removed the I Small Fix bugs fixed but nothing added label Sep 28, 2022
@applecuckoo
Copy link
Contributor

applecuckoo commented Oct 20, 2022

@RosaWagner @davelab6 any updates from your end? not sure if I'm being too annoying here...

According to rsms/inter#463 (reply in thread) we might not get Inter v4 stable until next year, so you should just onboard Inter v3.19, I'm sure many people need the proper italics. Also, v4 will actually drop the slnt axis due to poor browser support.

@applecuckoo
Copy link
Contributor

@RosaWagner hello? Just a bump since it doesn't seem that 3.19 will be onboarded soon.

@RosaWagner RosaWagner modified the milestones: 2022 Q4, 2023 Q1 Dec 2, 2022
@RosaWagner RosaWagner added -- Upstream is working on it Designer is making changes in the upstream repo and removed - In Progress labels Dec 2, 2022
@applecuckoo
Copy link
Contributor

@RosaWagner 3.19 is ready now, v4 can be onboarded in the future.

@applecuckoo
Copy link
Contributor

@davelab6 Has anyone been working here? Just to reiterate 3.19 is stable and ready to onboard, v4 is a while away.

@chrissimpkins chrissimpkins modified the milestones: 2023 Q1, Projects to be commissioned and/or milestoned Mar 2, 2023
@RosaWagner RosaWagner removed this from the Projects to be commissioned and/or milestoned milestone Mar 7, 2023
@RosaWagner RosaWagner added -- Regressions Shows diff with previous published version and removed -- Upstream is working on it Designer is making changes in the upstream repo labels Mar 9, 2023
@mon-jai
Copy link

mon-jai commented Mar 18, 2024

@m4rc1e Maybe send him an email?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Mar 18, 2024

@mon-jai already done this. I'm going to go for the packager option this week.

@rsms
Copy link

rsms commented Mar 19, 2024

@m4rc1e I've just prodded rasmus to see if we get a response. If we don't get a response, I'll see if we can add hotfixing to our packager.

Hi! How can I help?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Mar 19, 2024

Thanks for the reply, I opened a PR for you to review rsms/inter#678

@rsms
Copy link

rsms commented Mar 20, 2024

@m4rc1e PR looks good! Good idea to avoid a GF fork.
Just a couple of Qs: rsms/inter#678 (review)

@m4rc1e
Copy link
Collaborator

m4rc1e commented Mar 28, 2024

I'm still fixing up the pr but I should be done by tomorrow. I reckon we'll land this early next quarter. We still need to decide whether to call this family "Inter 4" due to the regressions.

@applecuckoo
Copy link
Contributor

@m4rc1e If Google Fonts does accept Inter 4 as a separate family, then it would be great if the older Inter 3.19 is brought on to replace the existing Inter family. It's the latest version that doesn't have any regressions with the existing Inter family, plus it has italics!

@chrissimpkins chrissimpkins modified the milestones: 2024 Q1, 2024 Q2 Apr 1, 2024
@mon-jai
Copy link

mon-jai commented Apr 22, 2024

@m4rc1e any updates?

@adityapatadia
Copy link

So how can we use this now this is merged?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jun 7, 2024

Family should land on the Google Fonts website in approximately two weeks.

@adityapatadia
Copy link

Thanks, btw what was the final decision? Is it going to be a new font or existing one will be automatically updated?

@Pogimon3
Copy link

Thanks, btw what was the final decision? Is it going to be a new font or existing one will be automatically updated?

It will most likely be a new font on google fonts because there are many regressions in the new version

see #3429 (comment)

@applecuckoo
Copy link
Contributor

applecuckoo commented Jun 20, 2024

No, it'll replace the existing version of Inter. See rsms/inter#678 (comment).

@Keavon
Copy link

Keavon commented Jun 20, 2024

That's great to hear, maybe some short-term pain but avoids future confusion long into the future. Can't wait for it to go live.

@Pogimon3
Copy link

Pogimon3 commented Jul 9, 2024

Family should land on the Google Fonts website in approximately two weeks.

Is this live yet? I don’t think so, i still see the older version on Google Fonts

@kairader-remo
Copy link

@m4rc1e just curious, will this be live soon?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jul 31, 2024

Been live since yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Regressions Shows diff with previous published version I Font Upgrade P3
Projects
Status: Live
Development

Successfully merging a pull request may close this issue.