Skip to content

latin: Add U+2122 (™) #78

Closed
Closed

Description

@criana

I recently discovered the Open Sans library via Google Fonts is missing the trademark symbol. It's currently an issue with a website I'm working on, and was able to verify it with the font preview tool on Google Fonts.

Although Adobe's version of the library has the TM. Any chance of getting the Google hosted library fixed?

opensans_trademarkcharactermissing

Activity

  1. enathu commented on Jul 14, 2015

    @enathu

    I have checked this issue with a CodePen, and the Trademark (™) sign is showing as intended. You can have a look at the CodePen here

    However, I can also confirm that that the Google Font preview tool, doesn't show the ™ mark in any font, as I've tried with it. May be it's an issue with preview tool, not with the font. Hope this get fixed.

    gf-tm

    Cheers.

  2. criana commented on Jul 14, 2015

    @criana
    Author

    @enathu thanks for sharing, that's very interesting. I wonder why on our site pulling the Open Sans font gives us the TM in a box representation.
    opensans_trademarkincopy

  3. criana commented on Jul 14, 2015

    @criana
    Author

    @enathu I just made a slight edit to the CodePen and was able to reproduce the issue. Remove "sans-serif" from after Open Sans and the TM becomes a [TM] in a box, broken character. I believe the library may still be missing this item and when "sans-serif" is supplied it defaults to the system sans-serif font which does contain that character.

    Does that make sense?

  4. enathu commented on Jul 14, 2015

    @enathu

    @criana Alright, that makes sense, now. So, I think it's an issue with GF API, since it's showing the same cross (missing glyphs) for all other fonts for trademark sign. Even though the trademark sign is inside the font file, as I just checked with the GF hosted Open Sans files.

    Pinging @davelab6 for fix. :)

  5. davelab6 commented on Jul 17, 2015

    @davelab6
    Member

    The directory's preview isn't an accurate reflection of the characters available in the font. The sans-serif thing is interesting, I'm not sure what is happening there... my guess is that when you add sans-serif then the browser uses the ™ that is in the default sans-serif font (likely Arial on windows) but when sans-serif is not there, is uses a default font (not sure what) which for some reason has this character in a box like that.

    I'm using a mac right now, and the ™ in the codepen does look slightly different with/without the sans-serif, but there is no box shape.

    The unicode U+2122 is not in the latin subsets, though, and thus isn't being served... so it could be a candidate for inclusion in the latin-ext subset.

    https://github.com/google/fonts/blob/master/tools/encodings/latin_unique-glyphs.nam

    https://github.com/google/fonts/blob/master/tools/encodings/latin-ext_unique-glyphs.nam

  6. changed the title [-]Open Sans Library Missing Trademark[/-] [+]Add U+2122 (™) to latin-ext[/+] on Jul 17, 2015
  7. self-assigned this
    on Jul 17, 2015
  8. codeman38 commented on Jul 17, 2015

    @codeman38

    U+2122 is part of the legacy Latin character sets for both Windows and Mac OS, so it feels like it should possibly even be included in latin.

    >>> u'\u2122'.encode('cp1252')
    '\x99'
    >>> u'\u2122'.encode('macroman')
    '\xaa'
    
  9. criana commented on Jul 17, 2015

    @criana
    Author

    @davelab6,
    Thanks for looking into this more. I've attached a screen shot of what I see in CodePen. I'm running Chrome on a Mac with OS 10.10.4. I also do no have any versions of OpenSans running locally on my machine. This is only when sans-serif is removed from the font-declaration.

    screen shot 2015-07-17 at 6 34 55 pm

  10. davelab6 commented on Jul 17, 2015

    @davelab6
    Member

    Here's what I see in Chrome 46, also 10.10.4, also none installed locally...

    screen shot 2015-07-17 at 18 48 19

  11. criana commented on Jul 17, 2015

    @criana
    Author

    I was able to verify this too after a thorough cleaning of fonts and caches on my machine. Sorry for the mixup.

  12. davelab6 commented on Jul 20, 2015

    @davelab6
    Member

    No worries @criana - the suggestion to add ™ is a good one :)

  13. BenRacicot commented on Oct 9, 2015

    @BenRacicot

    Hey @davelab6 any updates on this? I'm having the exact same issue as @criana perhaps someone has a nicer fix than adding a fallback font?

  14. 34 remaining items

  15. code23-isaac commented on Jan 21, 2019

    @code23-isaac

    Coming soon...

    image

  16. removed this from the milestone on Aug 13, 2021
  17. davelab6 commented on Dec 2, 2021

    @davelab6
    Member

    What I remembered was that Roozbeh left Google in the middle of this effort and no one picked it up since. Let's assign it to me and eventually we will deal with it

  18. davelab6 commented on Dec 2, 2021

    @davelab6
    Member

    Actually @RosaWagner says she can take the next steps on this so reassigning

  19. added this to the 2021 Q4 milestone on Dec 2, 2021
  20. davelab6 commented on Dec 2, 2021

    @davelab6
    Member

    Haha after looking further, this is already fixed

    https://fonts.googleapis.com/css?family=Open+Sans has

    /* latin */
    @font-face {
      font-family: 'Open Sans';
      font-style: normal;
      font-weight: 400;
      font-stretch: 100%;
      src: url(https://fonts.gstatic.com/s/opensans/v27/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsjZ0B4gaVIUx6EQ.woff2) format('woff2');
      unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
    }
    

    So u+2212 there means it will be provided by default when it exists in the font

    Thanks @RosaWagner for looking closer at this :)

  21. added a commit that references this issue on Sep 28, 2022
  22. added a commit that references this issue on Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

X Glyphset issueMissing glyphs to match a GF subset, wrong glyph mapping, unicode issue, or else

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions