-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latin: Add U+2122 (™) #78
Comments
I have checked this issue with a CodePen, and the Trademark (™) sign is showing as intended. You can have a look at the CodePen here However, I can also confirm that that the Google Font preview tool, doesn't show the ™ mark in any font, as I've tried with it. May be it's an issue with preview tool, not with the font. Hope this get fixed. Cheers. |
@enathu thanks for sharing, that's very interesting. I wonder why on our site pulling the Open Sans font gives us the TM in a box representation. |
@enathu I just made a slight edit to the CodePen and was able to reproduce the issue. Remove "sans-serif" from after Open Sans and the TM becomes a [TM] in a box, broken character. I believe the library may still be missing this item and when "sans-serif" is supplied it defaults to the system sans-serif font which does contain that character. Does that make sense? |
@criana Alright, that makes sense, now. So, I think it's an issue with GF API, since it's showing the same cross (missing glyphs) for all other fonts for trademark sign. Even though the trademark sign is inside the font file, as I just checked with the GF hosted Open Sans files. Pinging @davelab6 for fix. :) |
The directory's preview isn't an accurate reflection of the characters available in the font. The I'm using a mac right now, and the ™ in the codepen does look slightly different with/without the The unicode U+2122 is not in the latin subsets, though, and thus isn't being served... so it could be a candidate for inclusion in the https://github.com/google/fonts/blob/master/tools/encodings/latin_unique-glyphs.nam https://github.com/google/fonts/blob/master/tools/encodings/latin-ext_unique-glyphs.nam |
U+2122 is part of the legacy Latin character sets for both Windows and Mac OS, so it feels like it should possibly even be included in
|
@davelab6, |
I was able to verify this too after a thorough cleaning of fonts and caches on my machine. Sorry for the mixup. |
No worries @criana - the suggestion to add ™ is a good one :) |
Re-acknowledging this issue :) I'll see what I can do! |
Any update on this? Thanks :) |
Made up a quick Jsbin: |
It still does not render for a lot of us. Your JSbin renders for me (incorrectly) like this: Can you try testing on a fresh VM with Windows 10 + Chrome 59? On a VM here with that environment I get this (same behavior): I'd like to vote to reopen unless there is concrete proof that this isn't an issue, or the decision has been made for the ™ character to not be included in any subsets of Open Sans on Google Fonts. |
Thanks @qJake , Here's my screenshot on Win 10, Chrome 59. You're correct However, the glyph exists in the fonts: It gets served properly on OS X. I will look into this more. |
Thank you @roozbehp :D |
Shouldn't this issue stay open until the change is integrated? |
Ok, yes, reopening until your is plumbed all the way through to production :) |
Coming soon... |
Curious if there are any updates on this. I see it's been quite a while since there has been a post. I haven't read every post here, but if anyone needs to pull in a "pretty" TM for their site and they don't mind an extra request, you can do what I'm doing right now. I've placed this line at the end of my HTML's Then, you just make the above font (Choose whatever font you wish, of course. I just liked the TM in this one.) the second in your font stack in CSS. Not a perfect fix, but it's a decent workaround until there is a native TM in this font. You can also put it in the |
Yes the text API can work like that, although you should url encode the
character to make sure it is standards compliant html and works everywhere.
…On Tue, Jan 15, 2019, 7:19 PM Veronica Watt ***@***.*** wrote:
Curious if there are any updates on this. I see it's been quite a while
since there has been a post.
I haven't read every post here, but if anyone needs to pull in a "pretty"
TM for their site and they don't mind an extra request, you can do what I'm
doing right now. I've placed this line at the end of my HTML's <body>.
<link href="
https://fonts.googleapis.com/css?family=Cairo:300,400,600,700&text=™"
rel="stylesheet">
The "text=™" will pull only that glyph rather than the whole font
according to this
<https://developers.google.com/fonts/docs/getting_started#optimizing_your_font_requests>
.
Then, you just make the above font (Choose whatever font you wish, of
course. I just liked the TM in this one.) the second in your font stack in
CSS. Not a perfect fix, but it's a decent workaround until there is a
native TM in this font.
You can also put it in the <head>, but I felt that it was a small enough
enhancement that it wasn't something that should slow everything else down.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#78 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAP9y0PhQQdAJ1UM0j75KWp8kRTx-74Cks5vDnAogaJpZM4FYhFW>
.
|
What I remembered was that Roozbeh left Google in the middle of this effort and no one picked it up since. Let's assign it to me and eventually we will deal with it |
Actually @RosaWagner says she can take the next steps on this so reassigning |
Haha after looking further, this is already fixed https://fonts.googleapis.com/css?family=Open+Sans has
So u+2212 there means it will be provided by default when it exists in the font Thanks @RosaWagner for looking closer at this :) |
Update element_grid.textproto EGRD -> ELGR
West Frisian [fy]: remove {ij} and {íj́} from base
I recently discovered the Open Sans library via Google Fonts is missing the trademark symbol. It's currently an issue with a website I'm working on, and was able to verify it with the font preview tool on Google Fonts.
Although Adobe's version of the library has the TM. Any chance of getting the Google hosted library fixed?
The text was updated successfully, but these errors were encountered: