Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing EARLY_ACCESS.category for Open Sans Condensed. #5518

Closed
wants to merge 1 commit into from

Conversation

reitermarkus
Copy link
Contributor

No description provided.

@RosaWagner
Copy link
Contributor

RosaWagner commented Nov 9, 2022

Thanks @reitermarkus. Open Sans has been transferred to the ofl repo. It has a width axis and Open Sans Condensed has never been released. I think this directory should be removed instead from apache.

Needs confirmation from @davelab6 and @chrissimpkins
Maybe this is the opportunity to clean up the apache repo in a more general way, wdyt?

@RosaWagner RosaWagner added -- Needs confirmation from upstream or onboarder I Tools / workflow / repo -- Needs manager's opinion from upper level and removed -- Needs confirmation from upstream or onboarder labels Nov 9, 2022
@chrissimpkins
Copy link
Collaborator

Markus will you please let us know what you are attempting to do with the early release distribution?

@reitermarkus
Copy link
Contributor Author

reitermarkus commented Nov 12, 2022

We have a script to automatically import all Google Fonts to https://github.com/Homebrew/homebrew-cask-fonts.

If the EARLY_ACCESS.category exists, we use the https://fonts.google.com/earlyaccess page as homepage, otherwise we derive the https://fonts.google.com/specimen/* URL.

We also found that quite a few fonts are not actually released, i.e. don't have a matching https://fonts.google.com/specimen/* page, but also aren't on the https://fonts.google.com/earlyaccess page.

@chrissimpkins
Copy link
Collaborator

chrissimpkins commented Nov 24, 2022

Thanks Markus. The Early Access program should be considered obsolete and unsupported. We recommend that Homebrew not distribute these families. I'd be happy to discuss how we can support families that you are interested in and are not available beyond the early access metadata that you are adding here. Let's close this and take this conversation to the issue tracker or feel free to email me.

@davelab6
Copy link
Member

Agreed

@davelab6
Copy link
Member

davelab6 commented Dec 1, 2022

I discussed this a bit further with @RosaWagner and @vv-monsalve and it seems since we have these files for all other EA families and EA isn't actually shut down yet, we should merge this. It will be a null change for GF.

@davelab6
Copy link
Member

davelab6 commented Dec 1, 2022

Thanks @reitermarkus. Open Sans has been transferred to the ofl repo. It has a width axis and Open Sans Condensed has never been released.

Oh, wait. Rosalie is right, Open Sans Condensed was never in early access, it seems. So this PR doesn't make sense to me.

I believe the right thing is to delete the opensanscondensed directory.

@reitermarkus will that work for you?

@RosaWagner RosaWagner closed this Dec 2, 2022
@RosaWagner RosaWagner removed the -- Needs manager's opinion from upper level label Dec 2, 2022
@reitermarkus reitermarkus deleted the opensanscondensed-ea branch January 14, 2023 12:47
Dan0sz added a commit to Dan0sz/host-webfonts-locally that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants