Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourceserifpro: v2.000 added #605

Merged
merged 2 commits into from
Jan 25, 2017
Merged

Sourceserifpro: v2.000 added #605

merged 2 commits into from
Jan 25, 2017

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Jan 25, 2017

@davelab6 @frankrolf Only merge this If everyone is happy with #166 .

@frankrolf: I've made this pr include your pr, #603.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Jan 25, 2017

@frankrolf ^

@davelab6 davelab6 added this to the Update Families milestone Jan 25, 2017
@davelab6 davelab6 merged commit a61b1e3 into google:master Jan 25, 2017
@m4rc1e m4rc1e deleted the sourceserifpro branch December 5, 2017 14:16
@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Dec 5, 2017

Well it looks like I already filed this in Jan it never got pushed into prod.

FB Report

There is a total of 127 tests on <Section: Default>.
Start ... running 632 individual test executions.
>> com.google.fonts/test/006
   DESCRIPTION.en_us.html must have less than 1000 bytes.
 * FAIL: DESCRIPTION.en_us.html must have size smaller than 1000 bytes.

   Result: FAIL

>> com.google.fonts/test/029 with ((u'font[0]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Black.ttf'),)
   Check copyright namerecords match license file
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 1 (MACINTOSH) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]

   Result: FAIL

>> com.google.fonts/test/030 with ((u'font[0]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Black.ttf'),)
   "License URL matches License text on name table ?
 * FAIL: A License URL must be provided in the NameID 14 (LICENSE INFO URL) entry.

   Result: FAIL

>> com.google.fonts/test/042 with ((u'font[0]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Black.ttf'),)
   Checking OS/2 Metrics match hhea Metrics.
 * FAIL: OS/2 sTypoAscender and hhea ascent must be equal. [code: ascender]

   Result: FAIL

>> com.google.fonts/test/057 with ((u'font[0]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Black.ttf'),)
   Name table entries should not contain line-breaks.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform MACINTOSH contains a line-break.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.

   Result: FAIL

>> com.google.fonts/test/074 with ((u'font[0]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Black.ttf'),)
   Are there non-ASCII characters in ASCII-only NAME table entries ?
 * FAIL: There are 2 strings containing non-ASCII characters in the ASCII-only NAME table entries.

   Result: FAIL

>> com.google.fonts/test/102 with ((u'font[0]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Black.ttf'),)
   Copyright notice on METADATA.pb matches canonical pattern ?
 * FAIL: METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright 2014, 2015, 2016 Adobe Systems Incorporated (http://www.adobe.com/), with Reserved Font Name 'Source'.'

   Result: FAIL

>> com.google.fonts/test/029 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Bold.ttf'),)
   Check copyright namerecords match license file
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 1 (MACINTOSH) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]

   Result: FAIL

>> com.google.fonts/test/030 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Bold.ttf'),)
   "License URL matches License text on name table ?
 * FAIL: A License URL must be provided in the NameID 14 (LICENSE INFO URL) entry.

   Result: FAIL

>> com.google.fonts/test/042 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Bold.ttf'),)
   Checking OS/2 Metrics match hhea Metrics.
 * FAIL: OS/2 sTypoAscender and hhea ascent must be equal. [code: ascender]

   Result: FAIL

>> com.google.fonts/test/057 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Bold.ttf'),)
   Name table entries should not contain line-breaks.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform MACINTOSH contains a line-break.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.

   Result: FAIL

>> com.google.fonts/test/074 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Bold.ttf'),)
   Are there non-ASCII characters in ASCII-only NAME table entries ?
 * FAIL: There are 2 strings containing non-ASCII characters in the ASCII-only NAME table entries.

   Result: FAIL

>> com.google.fonts/test/102 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Bold.ttf'),)
   Copyright notice on METADATA.pb matches canonical pattern ?
 * FAIL: METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright 2014, 2015, 2016 Adobe Systems Incorporated (http://www.adobe.com/), with Reserved Font Name 'Source'.'

   Result: FAIL

>> com.google.fonts/test/154 with ((u'font[1]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Bold.ttf'),)
   Check font has same encoded glyphs as version hosted on fonts.google.com
 * FAIL: Font is missing the following glyphs from the previous release [0x0000, 0x000D]

   Result: FAIL

>> com.google.fonts/test/029 with ((u'font[2]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-ExtraLight.ttf'),)
   Check copyright namerecords match license file
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 1 (MACINTOSH) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]

   Result: FAIL

>> com.google.fonts/test/030 with ((u'font[2]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-ExtraLight.ttf'),)
   "License URL matches License text on name table ?
 * FAIL: A License URL must be provided in the NameID 14 (LICENSE INFO URL) entry.

   Result: FAIL

>> com.google.fonts/test/042 with ((u'font[2]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-ExtraLight.ttf'),)
   Checking OS/2 Metrics match hhea Metrics.
 * FAIL: OS/2 sTypoAscender and hhea ascent must be equal. [code: ascender]

   Result: FAIL

>> com.google.fonts/test/057 with ((u'font[2]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-ExtraLight.ttf'),)
   Name table entries should not contain line-breaks.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform MACINTOSH contains a line-break.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.

   Result: FAIL

>> com.google.fonts/test/074 with ((u'font[2]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-ExtraLight.ttf'),)
   Are there non-ASCII characters in ASCII-only NAME table entries ?
 * FAIL: There are 2 strings containing non-ASCII characters in the ASCII-only NAME table entries.

   Result: FAIL

>> com.google.fonts/test/102 with ((u'font[2]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-ExtraLight.ttf'),)
   Copyright notice on METADATA.pb matches canonical pattern ?
 * FAIL: METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright 2014, 2015, 2016 Adobe Systems Incorporated (http://www.adobe.com/), with Reserved Font Name 'Source'.'

   Result: FAIL

>> com.google.fonts/test/029 with ((u'font[3]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Light.ttf'),)
   Check copyright namerecords match license file
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 1 (MACINTOSH) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]

   Result: FAIL

>> com.google.fonts/test/030 with ((u'font[3]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Light.ttf'),)
   "License URL matches License text on name table ?
 * FAIL: A License URL must be provided in the NameID 14 (LICENSE INFO URL) entry.

   Result: FAIL

>> com.google.fonts/test/042 with ((u'font[3]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Light.ttf'),)
   Checking OS/2 Metrics match hhea Metrics.
 * FAIL: OS/2 sTypoAscender and hhea ascent must be equal. [code: ascender]

   Result: FAIL

>> com.google.fonts/test/057 with ((u'font[3]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Light.ttf'),)
   Name table entries should not contain line-breaks.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform MACINTOSH contains a line-break.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.

   Result: FAIL

>> com.google.fonts/test/074 with ((u'font[3]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Light.ttf'),)
   Are there non-ASCII characters in ASCII-only NAME table entries ?
 * FAIL: There are 2 strings containing non-ASCII characters in the ASCII-only NAME table entries.

   Result: FAIL

>> com.google.fonts/test/102 with ((u'font[3]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Light.ttf'),)
   Copyright notice on METADATA.pb matches canonical pattern ?
 * FAIL: METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright 2014, 2015, 2016 Adobe Systems Incorporated (http://www.adobe.com/), with Reserved Font Name 'Source'.'

   Result: FAIL

>> com.google.fonts/test/029 with ((u'font[4]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Regular.ttf'),)
   Check copyright namerecords match license file
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 1 (MACINTOSH) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]

   Result: FAIL

>> com.google.fonts/test/030 with ((u'font[4]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Regular.ttf'),)
   "License URL matches License text on name table ?
 * FAIL: A License URL must be provided in the NameID 14 (LICENSE INFO URL) entry.

   Result: FAIL

>> com.google.fonts/test/042 with ((u'font[4]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Regular.ttf'),)
   Checking OS/2 Metrics match hhea Metrics.
 * FAIL: OS/2 sTypoAscender and hhea ascent must be equal. [code: ascender]

   Result: FAIL

>> com.google.fonts/test/057 with ((u'font[4]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Regular.ttf'),)
   Name table entries should not contain line-breaks.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform MACINTOSH contains a line-break.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.

   Result: FAIL

>> com.google.fonts/test/074 with ((u'font[4]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Regular.ttf'),)
   Are there non-ASCII characters in ASCII-only NAME table entries ?
 * FAIL: There are 2 strings containing non-ASCII characters in the ASCII-only NAME table entries.

   Result: FAIL

>> com.google.fonts/test/102 with ((u'font[4]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Regular.ttf'),)
   Copyright notice on METADATA.pb matches canonical pattern ?
 * FAIL: METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright 2014, 2015, 2016 Adobe Systems Incorporated (http://www.adobe.com/), with Reserved Font Name 'Source'.'

   Result: FAIL

>> com.google.fonts/test/154 with ((u'font[4]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-Regular.ttf'),)
   Check font has same encoded glyphs as version hosted on fonts.google.com
 * FAIL: Font is missing the following glyphs from the previous release [0x0000, 0x000D]

   Result: FAIL

>> com.google.fonts/test/029 with ((u'font[5]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-SemiBold.ttf'),)
   Check copyright namerecords match license file
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 1 (MACINTOSH) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]
 * FAIL: License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "This Font Software is licensed under the SIL Open Font License, Version 1.1.

This Font Software is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the SIL Open Font License for the specific language, permissions and limitations governing your use of this Font Software." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL" [code: wrong]

   Result: FAIL

>> com.google.fonts/test/030 with ((u'font[5]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-SemiBold.ttf'),)
   "License URL matches License text on name table ?
 * FAIL: A License URL must be provided in the NameID 14 (LICENSE INFO URL) entry.

   Result: FAIL

>> com.google.fonts/test/042 with ((u'font[5]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-SemiBold.ttf'),)
   Checking OS/2 Metrics match hhea Metrics.
 * FAIL: OS/2 sTypoAscender and hhea ascent must be equal. [code: ascender]

   Result: FAIL

>> com.google.fonts/test/057 with ((u'font[5]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-SemiBold.ttf'),)
   Name table entries should not contain line-breaks.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform MACINTOSH contains a line-break.
 * FAIL: Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break.

   Result: FAIL

>> com.google.fonts/test/074 with ((u'font[5]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-SemiBold.ttf'),)
   Are there non-ASCII characters in ASCII-only NAME table entries ?
 * FAIL: There are 2 strings containing non-ASCII characters in the ASCII-only NAME table entries.

   Result: FAIL

>> com.google.fonts/test/102 with ((u'font[5]', '/Users/marc/Documents/googlefonts/fonts/ofl/sourceserifpro/SourceSerifPro-SemiBold.ttf'),)
   Copyright notice on METADATA.pb matches canonical pattern ?
 * FAIL: METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright 2014, 2015, 2016 Adobe Systems Incorporated (http://www.adobe.com/), with Reserved Font Name 'Source'.'

   Result: FAIL

======== <Section: Default> ========
632 tests in section


Section results:

    ERROR: 0
    FAIL: 39
    WARN: 57
    SKIP: 40
    INFO: 31
    PASS: 465

======== END <Section: Default> ========

Total:

    ERROR: 0
    FAIL: 39
    WARN: 57
    SKIP: 40
    INFO: 31
    PASS: 465


DONE!


Since we now have diffbrowsers, here are the some renders against v1.013 which is currently served on GF.

Regression Report:

Fonts: ["SourceSerifPro-Black.ttf", "SourceSerifPro-Bold.ttf", "SourceSerifPro-ExtraLight.ttf", "SourceSerifPro-Light.ttf", "SourceSerifPro-Regular.ttf", "SourceSerifPro-SemiBold.ttf"]

View: glyphs-modified
WARNING: Desktop_OS_X_El_Capitan_safari_9.1_.jpg is different by 378247 pixels

View: waterfall
WARNING: Desktop_OS_X_El_Capitan_safari_9.1_.jpg is different by 443170 pixels
WARNING: Desktop_Windows_7_ie_9.0_.jpg is different by 368355 pixels
WARNING: Desktop_Windows_7_chrome_50.0_.jpg is different by 369800 pixels
WARNING: Desktop_Windows_10_edge_15.0_.jpg is different by 369411 pixels
WARNING: Desktop_Windows_7_firefox_45.0_.jpg is different by 352658 pixels


Glyphs modified
desktop_os_x_el_capitan_safari_9 1_

We can see that the bold is slightly heavier

desktop_os_x_el_capitan_safari_9 1_
El Capitan

@frankrolf
Copy link
Contributor

The vertical shift is expected, since Vietnamese accents were added in 2.0
Shortly after the initial release, we added three more weights, and re-thought the interpolation scheme, which resulted in heavier Semibold and Bold weights:
See also: https://github.com/adobe-fonts/source-serif-pro/releases/1.017R

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Dec 6, 2017

@frankrolf thank you for your write up.

Since our api doesn't do versioning, I'm questioning whether such changes will upset people. I will leave this up to Dave to decide.

@frankrolf
Copy link
Contributor

In the spirit of release early, release often, we made sure the 6-weight release would follow the initial release ASAP, in order to upset as few users as possible. Unfortunately, this intention was somewhat nullified by the old fonts sticking around on Google for so long.

We provide all past releases for individual projects in the Github “releases” tab, so if anyone really is hurting for the old Fonts, they can get them there.

All I remember users complaining about is the fonts on Google not being current.

@frankrolf
Copy link
Contributor

@davelab6 I am curious about the status of this.

@davelab6
Copy link
Member

@frankrolf due to unforeseen circumstances, I wasn't able to get this pushed yet, and there is now a production freeze over the US holidays, but this should go out in early January :)

@frankrolf
Copy link
Contributor

@davelab6 Any status updates here?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants