-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reddit Mono: Version 1.014 added #7315
Conversation
* Reddit Mono Version 1.014 taken from the upstream repo https://github.com/reddit/redditsans at commit reddit/redditsans@60e19b5.
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.12.0a2 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] RedditMono[wght].ttf🔥 FAIL: Ensure the font supports case swapping for all its glyphs. (com.google.fonts/check/case_mapping)
[code: missing-case-counterparts] ℹ INFO: METADATA.pb: Validate family.repository_url field. (com.google.fonts/check/metadata/minisite_url)
All other checks[21] RedditMono[wght].ttf🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb (com.google.fonts/check/metadata/valid_copyright)
"Copyright 2020 The Familyname Project Authors (git url)" But instead we have got: "copyright (c) 2020-2023, reddit, inc. (https://github.com/reddit/redditsans)" [code: bad-notice-format] 🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
"reddit sans" which does not match the expected format, similar to: "Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format] 🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
"Copyright 2019 The Familyname Project Authors (git url)" But instead we have got: "Copyright (c) 2020-2023, Reddit, Inc. (https://github.com/reddit/redditsans)" 🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
⚠ WARN: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (com.google.fonts/check/alt_caron)
⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
Lines changed: - \n + Copyright © 2020-23, Reddit, Inc. (https://github.com/reddit/redditsans)\n - https://openfontlicense.org\n + https://openfontlicense.org/\n + Reddit Sans Condensed\n + Copyright © 2020-23, Reddit, Inc. (https://github.com/reddit/redditsans)\n + This Font Software is licensed under the SIL Open Font License, Version 1.1.\n + This license is copied below, and is also available with a FAQ at:\n + https://openfontlicense.org/\n - -----------------------------------------------------------\n - SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007\n - -----------------------------------------------------------\n + Reddit Mono\n + Copyright © 2020-23, Reddit, Inc. (https://github.com/reddit/redditsans)\n + This Font Software is licensed under the SIL Open Font License, Version 1.1.\n + This license is copied below, and is also available with a FAQ at:\n + https://openfontlicense.org/\n + ---\n + \n + ## SIL OPEN FONT LICENSE\n + \n + Version 1.1 - 26 February 2007\n + \n - PREAMBLE\n + ### PREAMBLE\n + \n - The goals of the Open Font License (OFL) are to stimulate worldwide\n + The goals of the Open Font License (OFL) are to stimulate worldwide development\n - development of collaborative font projects, to support the font creation\n + of collaborative font projects, to support the font creation efforts of academic\n + and linguistic communities, and to provide a free and open framework in which\n + fonts may be shared and improved in partnership with others.\n - efforts of academic and linguistic communities, and to provide a free and\n - open framework in which fonts may be shared and improved in partnership\n - with others.\n - redistributed freely as long as they are not sold by themselves. The\n + redistributed freely as long as they are not sold by themselves. The fonts,\n - fonts, including any derivative works, can be bundled, embedded,\n + including any derivative works, can be bundled, embedded, redistributed and/or\n - redistributed and/or sold with any software provided that any reserved\n - names are not used by derivative works. The fonts and derivatives,\n - however, cannot be released under any other type of license. The\n - requirement for fonts to remain under this license does not apply\n - to any document created using the fonts or their derivatives.\n + sold with any software provided that any reserved names are not used by\n + derivative works. The fonts and derivatives, however, cannot be released under\n + any other type of license. The requirement for fonts to remain under this\n + license does not apply to any document created using the fonts or their\n + derivatives.\n - DEFINITIONS\n + ### DEFINITIONS\n - "Font Software" refers to the set of files released by the Copyright\n - Holder(s) under this license and clearly marked as such. This may\n - include source files, build scripts and documentation.\n + "Font Software" refers to the set of files released by the Copyright Holder(s)\n + under this license and clearly marked as such. This may include source files,\n + build scripts and documentation.\n + \n - "Reserved Font Name" refers to any names specified as such after the\n + "Reserved Font Name" refers to any names specified as such after the copyright\n - copyright statement(s).\n + statement(s).\n - "Modified Version" refers to any derivative made by adding to, deleting,\n + "Modified Version" refers to any derivative made by adding to, deleting, or\n - or substituting -- in part or in whole -- any of the components of the\n + substituting — in part or in whole — any of the components of the Original\n - Original Version, by changing formats or by porting the Font Software to a\n + Version, by changing formats or by porting the Font Software to a new\n - new environment.\n + environment.\n - "Author" refers to any designer, engineer, programmer, technical\n + "Author" refers to any designer, engineer, programmer, technical writer or other\n - writer or other person who contributed to the Font Software.\n + person who contributed to the Font Software.\n - PERMISSION & CONDITIONS\n + ### PERMISSION & CONDITIONS\n - Permission is hereby granted, free of charge, to any person obtaining\n - a copy of the Font Software, to use, study, copy, merge, embed, modify,\n - redistribute, and sell modified and unmodified copies of the Font\n - Software, subject to the following conditions:\n - 1) Neither the Font Software nor any of its individual components,\n - in Original or Modified Versions, may be sold by itself.\n + Permission is hereby granted, free of charge, to any person obtaining a copy of\n + the Font Software, to use, study, copy, merge, embed, modify, redistribute, and\n + sell modified and unmodified copies of the Font Software, subject to the\n + following conditions:\n + 1. Neither the Font Software nor any of its individual components, in Original\n + or Modified Versions, may be sold by itself.\n - 2) Original or Modified Versions of the Font Software may be bundled,\n - redistributed and/or sold with any software, provided that each copy\n - contains the above copyright notice and this license. These can be\n - included either as stand-alone text files, human-readable headers or\n - in the appropriate machine-readable metadata fields within text or\n - binary files as long as those fields can be easily viewed by the user.\n - 3) No Modified Version of the Font Software may use the Reserved Font\n - Name(s) unless explicit written permission is granted by the corresponding\n - Copyright Holder. This restriction only applies to the primary font name as\n - presented to the users.\n + 2. Original or Modified Versions of the Font Software may be bundled,\n + redistributed and/or sold with any software, provided that each copy contains\n + the above copyright notice and this license. These can be included either as\n + stand-alone text files, human-readable headers or in the appropriate\n + machine-readable metadata fields within text or binary files as long as those\n + fields can be easily viewed by the user.\n + 3. No Modified Version of the Font Software may use the Reserved Font Name(s)\n + unless explicit written permission is granted by the corresponding Copyright\n + Holder. This restriction only applies to the primary font name as presented\n + to the users.\n - 4) The name(s) of the Copyright Holder(s) or the Author(s) of the Font\n - Software shall not be used to promote, endorse or advertise any\n - Modified Version, except to acknowledge the contribution(s) of the\n - Copyright Holder(s) and the Author(s) or with their explicit written\n - permission.\n + 4. The name(s) of the Copyright Holder(s) or the Author(s) of the Font Software\n + shall not be used to promote, endorse or advertise any Modified Version,\n + except to acknowledge the contribution(s) of the Copyright Holder(s) and the\n + Author(s) or with their explicit written permission.\n - 5) The Font Software, modified or unmodified, in part or in whole,\n - must be distributed entirely under this license, and must not be\n - distributed under any other license. The requirement for fonts to\n - remain under this license does not apply to any document created\n - using the Font Software.\n - TERMINATION\n - This license becomes null and void if any of the above conditions are\n - not met.\n + 5. The Font Software, modified or unmodified, in part or in whole, must be\n + distributed entirely under this license, and must not be distributed under\n + any other license. The requirement for fonts to remain under this license\n + does not apply to any document created using the Font Software.\n + ### TERMINATION\n + \n + This license becomes null and void if any of the above conditions are not met.\n + \n - DISCLAIMER\n + ### DISCLAIMER\n + \n - THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,\n + THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n - EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF\n + IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF MERCHANTABILITY, FITNESS\n + FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF COPYRIGHT, PATENT, TRADEMARK, OR\n + OTHER RIGHT. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM,\n + DAMAGES OR OTHER LIABILITY, INCLUDING ANY GENERAL, SPECIAL, INDIRECT,\n + INCIDENTAL, OR CONSEQUENTIAL DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR\n - MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT\n - OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE\n - COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,\n - INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL\n - DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING\n - FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM\n + OTHERWISE, ARISING FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR\n - OTHER DEALINGS IN THE FONT SOFTWARE. + FROM OTHER DEALINGS IN THE FONT SOFTWARE. [code: incorrect-ofl-body-text] ⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
Summary
Note: The following loglevels were omitted in this report:
|
737d4a7: [gftools-packager] Reddit Mono: Version 1.014 added
c1e8391: Description updated