Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Sans Hebrew: Version 2.004 added #7588

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

simoncozens
Copy link
Collaborator

Taken from the upstream repo https://github.com/notofonts/hebrew at commit notofonts/hebrew@0688e5f.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
  • Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@simoncozens
Copy link
Collaborator Author

This release:

* Fixes interpolation issues
* Corrects the width (#39) and position of marks under double-yud and double-vov (#38, thanks to @markhdavid)
* Removes semibold masters
* Adds the U+053F yod triangle character (#46)
* Improves the spacing of decomposed dagesh forms (#47)

@simoncozens simoncozens linked an issue Apr 22, 2024 that may be closed by this pull request
Copy link

FontBakery report

fontbakery version: 0.12.3

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] NotoSansHebrew[wdth,wght].ttf
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]

All other checks

[10] NotoSansHebrew[wdth,wght].ttf
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 572 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 322: minus

[code: width-outliers]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̧̀ į̧́ į̧̂ į̧̃

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Koonzime (Latn, 40,000 speakers), Cicipu (Latn, 44,000 speakers), Ma’di (Latn, 584,000 speakers), Dii (Latn, 71,000 speakers), Makaa (Latn, 221,000 speakers), Sar (Latn, 500,000 speakers), Lugbara (Latn, 2,200,000 speakers), Mundani (Latn, 34,000 speakers), Bafut (Latn, 158,146 speakers), Kom (Latn, 360,685 speakers), Igbo (Latn, 27,823,640 speakers), Mfumte (Latn, 79,000 speakers), South Central Banda (Latn, 244,000 speakers), Ebira (Latn, 2,200,000 speakers), Ejagham (Latn, 120,000 speakers), Fur (Latn, 1,230,163 speakers), Nzakara (Latn, 50,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Nateni (Latn, 100,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Gulay (Latn, 250,478 speakers), Basaa (Latn, 332,940 speakers), Navajo (Latn, 166,319 speakers), Avokaya (Latn, 100,000 speakers), Zapotec (Latn, 490,000 speakers), Mango (Latn, 77,000 speakers), Southern Kisi (Latn, 360,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ekpeye (Latn, 226,000 speakers), Yala (Latn, 200,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Dan (Latn, 1,099,244 speakers), Aghem (Latn, 38,843 speakers).

[code: soft-dotted]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, math, coptic
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, math, canadian-aboriginal, coptic, tai-le, malayalam, old-permic, syriac
  • U+030A COMBINING RING ABOVE: try adding syriac 6 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic-ext, greek-ext, hebrew, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/notosanshebrew


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/notosanshebrew/NotoSansHebrew[wdth,wght].ttf
Dehinted Size 141.6kb
Hinted Size 141.6kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.004']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght-wdth', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 0 4 42 8 195 0
0% 0% 0% 2% 17% 3% 78% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e m4rc1e merged commit 3e8629e into main Apr 26, 2024
7 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_notosanshebrew branch April 26, 2024 10:39
@markhdavid
Copy link

@simoncozens or @m4rc1e do you know of any reason Noto Sans Hebrew is missing from the Project Board? Similar to my comments here, which have received no reply. I'm concerned this might have fallen through the cracks. Thanks.
Noto Sand Hebrew Missing on Fonts Traffic Jam - Screenshot 2024-05-01 at 7 11 25 AM

@m4rc1e
Copy link
Collaborator

m4rc1e commented May 1, 2024

@markhdavid I'm working on a fix that'll automatically add them to the board.

@simoncozens
Copy link
Collaborator Author

I think the main reason is that I added this to the "Google Fonts" project instead of the "Fonts Traffic Jam" project by mistake...

@markhdavid
Copy link

Hi @simoncozens and @m4rc1e are we still on track? Since over 2 weeks ago, seems nothing changed. Overall it's been about 4 weeks since initial PR. Thank you.

@simoncozens
Copy link
Collaborator Author

There was a problem with our development server which has since been resolved. We are still on track because I don't remember promising a particular timescale. :-) It has not been forgotten and will be moved along the pipeline in order.

@emmamarichal emmamarichal changed the title Noto Sans Hebrew: Version 2.004 added Noto Sans Hebrew: Version 2.004 added Jun 21, 2024
@emmamarichal
Copy link
Collaborator

@simoncozens @m4rc1e

I have no clue of why this PR is blocked, but I inspected a bit the fonts: The version on GF is the 3.001, and here we have the 2.004.

The ID1 changed also. Any idea of what happened here?

Screenshot 2024-06-21 at 14 57 46

@simoncozens
Copy link
Collaborator Author

While this PR was blocked, there was a decision to move to a new version. This PR superseded by #7806.

@emmamarichal
Copy link
Collaborator

Oh I see. The board hasn't been updated. I'll do it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update Noto {Sans,Rashi,Serif} Hebrew
4 participants