-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noto Serif JP: Version 2.003-H1;hotconv 1.1.1;makeotfexe 2.6.0 added #8051
Conversation
ef8da67
to
b5ed8ca
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Relevant release notes:
|
b5ed8ca
to
176cb64
Compare
176cb64
to
8a7c748
Compare
FontBakery reportfontbakery version: 0.12.10 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [1] NotoSerifJP[wght].ttfAll other checks[28] NotoSerifJP[wght].ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'http://www.adobe.com' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Does DESCRIPTION file contain broken links?
🔥 FAIL Combined length of family and style must not exceed 32 characters.
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]🔥 FAIL Check license file has good copyright string.
"copyright 2012 google inc. all rights reserved." which does not match the expected format, similar to: "Copyright 2022 The Familyname Project Authors (git url)" [code: bad-format]🔥 FAIL Ensure dotted circle glyph is present and can attach marks.
[code: unattached-dotted-circle-marks] 🔥 FAIL Ensure files are not too large.
🔥 FAIL Copyright notices match canonical pattern in fonts
"Copyright 2020 The Familyname Project Authors (git url)" But instead we have got: "(c) 2017-2024 Adobe (http://www.adobe.com/)." [code: bad-notice-format]
"Copyright 2020 The Familyname Project Authors (git url)" But instead we have got: "(c) 2017-2024 Adobe (http://www.adobe.com/)." [code: bad-notice-format]
|
ofl/notoserifjp/NotoSerifJP[wght].ttf | |
---|---|
Dehinted Size | 12.9Mb |
Hinted Size | 12.9Mb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font has old ttfautohint applied?
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.003-H1;hotconv 1.1.1;makeotfexe 2.6.0']
[code: version-not-detected]
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 9 | 13 | 51 | 8 | 170 | 0 |
0% | 0% | 4% | 5% | 20% | 3% | 68% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Taken from the upstream repo https://www.github.com/notofonts/noto-cjk at commit https://www.github.com/notofonts/noto-cjk/commit/985fa52c81c1d6692ccdd82bc3656e8fb932fd89.
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectsprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.