Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize frame group thumbnails with filmstrip. #1062

Merged
merged 2 commits into from
Sep 12, 2017
Merged

Synchronize frame group thumbnails with filmstrip. #1062

merged 2 commits into from
Sep 12, 2017

Conversation

ben-clayton
Copy link
Contributor

Fixes: #1056

dsrbecky
dsrbecky reviewed Sep 6, 2017
View reviewed changes
Copy link
Contributor

@dsrbecky dsrbecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this break the frame thumbnails by undoing the previous improvements?

@ben-clayton
Copy link
Contributor Author

Doesn't this break the frame thumbnails by undoing the previous improvements?

It shouldn't. The 'look for last draw call' is an improvement for groups that do something nasty, like unbinding the framebuffer after the last draw call. This was important before we had the gvr commands being traced. Now that they are, gvr_frame_submit is annotated with @frame_end, and the correct frame is shown. In cases were we have user marker groups, we still default to the 'look for last draw call' heuristic, and this works as it did before.

@ben-clayton
Copy link
Contributor Author

PTAL

@ben-clayton
gapis/api: Tidy api.AddGroup.
430a65d 
Never return val, err. They must be mutually exclusively nil or non-nil.
Use the standard 'out' variable name.
@ben-clayton
Synchronize frame group thumbnails with filmstrip.
91d883b 
Fixes: google#1056
@ben-clayton ben-clayton merged commit c5bbcc8 into google:master Sep 12, 2017
@ben-clayton ben-clayton deleted the sync-frame-thumbs branch September 12, 2017 21:42
purvisa-at-google-com pushed a commit that referenced this pull request Sep 29, 2022
@yalcinmelihyasin
implement VK_EXT_load_store_op_none (#1062)
88d9fd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsrbecky dsrbecky dsrbecky left review comments

@pmuetschard pmuetschard pmuetschard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ben-clayton @dsrbecky @pmuetschard