Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tracing on Windows in MINGW. #1153

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Fixed tracing on Windows in MINGW. #1153

merged 1 commit into from
Oct 4, 2017

Conversation

AWoloszyn
Copy link
Contributor

We were incorrectly relying on the order of evaluation of
left-hand and right-hand side of assignments. This meant
that values were not correct of evaluating LHS first.

@AWoloszyn
Fixed tracing on Windows in MINGW.
03f7067 
We were incorrectly relying on the order of evaluation of
left-hand and right-hand side of assignments. This meant
that values were not correct of evaluating LHS first.
ben-clayton
ben-clayton approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@AWoloszyn AWoloszyn merged commit 15d0219 into google:master Oct 4, 2017
@AWoloszyn AWoloszyn deleted the fix-map-ref branch May 8, 2018 13:23
purvisa-at-google-com pushed a commit that referenced this pull request Sep 29, 2022
@pmuetschard
Fix encoding of pointers of 32bit apps.
b4c0390 
Fixes #1153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-clayton ben-clayton ben-clayton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AWoloszyn @ben-clayton