Various fixes for eglMakeCurrent. #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be nullptr if this extension is used: https://www.khronos.org/registry/EGL/extensions/KHR/EGL_KHR_surfaceless_context.txt
Make the tests more correct while we’re at it.
dsrbecky
approved these changes
Oct 6, 2017
gapii/cc/spy.cpp
Outdated
| @@ -372,10 +368,6 @@ std::shared_ptr<StaticContextState> GlesSpy::GetEGLStaticContextState(CallObserv | |||
| } | |||
|
|
|||
| std::shared_ptr<DynamicContextState> GlesSpy::GetEGLDynamicContextState(CallObserver* observer, EGLDisplay display, EGLSurface draw, EGLContext context) { | |||
| if (draw == nullptr) { | |||
There was a problem hiding this comment.
Ideally add a comment saying 'draw' may be null, otherwise it will be forgotten in couple of months?
There was a problem hiding this comment.
Just removed the unused parameters instead.
There was a problem hiding this comment.
Humm... except they were used. Bugger.
One for tomorrow (today), I think.
from GetEGLStaticContextState. It’s not used.
dsrbecky
reviewed
Oct 6, 2017
gapir/cc/windows/gles_renderer.cpp
Outdated
| if (mPBuf == nullptr) { | ||
| GAPID_FATAL("wglCreatePbufferARB failed. Error: 0x%x", GetLastError()); | ||
| GAPID_FATAL("wglCreatePbufferARB(%p, %d, %d, %d, %p) failed. Error: 0x%x", | ||
| mHDC, format, safe_width, safe_height, create_attribs, GetLastError()); |
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
Visualize GPU frequencies from different counters with a shared maximum range value. Add hs_err_pid* log java runtime files to the ignore list;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.