gapis/api/sync: Don't explode if GetTerminator returns a nil. #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
reviewed
Aug 22, 2017
gapis/api/sync/sync.go
Outdated
| @@ -81,7 +81,9 @@ func MutationCmdsFor(ctx context.Context, c *path.Capture, cmds []api.Cmd, id ap | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| terminators = append(terminators, term) | |||
| if term != nil { | |||
There was a problem hiding this comment.
You probably want to insert the EarlyTerminator in this case (or return it from GetTerminator), otherwise all commands for this API will be kept even if you only want a subset of the commands.
ben-clayton
force-pushed
the
get-term-fix
branch
from
9068c48
to
8a477f2
Compare
AWoloszyn
approved these changes
Aug 22, 2017
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
Calculate size of texture to display in texture list - Added size to the texture proto, calculated based on format - Displays the total size from each depth/layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.