Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/bucket names crawler #234

Merged
merged 10 commits into from
Jul 3, 2023
Merged

Feat/bucket names crawler #234

merged 10 commits into from
Jul 3, 2023

Conversation

sudiptob2
Copy link
Contributor

related to #228

  • Updated crawler interface
  • Implemented storage bucket crawler.
  • moved configuration logic to the crawler factory for the storage bucket

Challenges

  • Even though it implements the ICrawler interface, it does not fully respect the contract. (Ex, return type is different) The code works though.

@sudiptob2 sudiptob2 marked this pull request as draft June 29, 2023 06:58
@sudiptob2 sudiptob2 marked this pull request as ready for review June 29, 2023 07:16
@sudiptob2 sudiptob2 mentioned this pull request Jun 29, 2023
Merged
mshudrak
mshudrak requested changes Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@mshudrak mshudrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, other than that looks pretty good.

src/gcp_scanner/crawler/bucket_names_crawler.py Outdated
from gcp_scanner.crawler.interface_crawler import ICrawler


class BucketNamesCrawler(ICrawler):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I am a bit confused :) you have bucket_names_crawler and storage_buckets_crawler. I think this file was added by accident or am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshudrak Thanks 🚀 I did not notice this one 😕 Updated now

@sudiptob2 sudiptob2 requested a review from mshudrak July 3, 2023 03:40
mshudrak
mshudrak approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@mshudrak mshudrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, THX.

@mshudrak mshudrak merged commit a9e4673 into google:main Jul 3, 2023
@sudiptob2 sudiptob2 deleted the feat/bucket-names-crawler branch July 3, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshudrak mshudrak mshudrak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudiptob2 @mshudrak