Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-formatting issue #69

Merged

Conversation

boomanaiden154
Copy link
Collaborator

This patch fixes a clang-formatting issue introduced in a previous patch.

Copy link
Collaborator

@ondrasej ondrasej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like a clang-format problem to me (the single quotes are part of the output, they surround the basic block hex string).

@boomanaiden154
Copy link
Collaborator Author

boomanaiden154 commented Mar 11, 2024

This doesn't look like a clang-format problem to me (the single quotes are part of the output, they surround the basic block hex string).

Clang-format was failing earlier, adjusting that line (https://github.com/google/gematria/actions/runs/8213023159/job/22463938919). I was mostly just trying to experiment with getting the CI working again in this PR after the bazel tests continued to fail. When you reviewed it, this patch essentially just reverted the formatting patch, but that wasn't the issue with the bazel CI. Still need to figure out what's going on there. I suspect python dependencies being transient due to the lack of a lockfile, but have yet to confirm.

@boomanaiden154
Copy link
Collaborator Author

Going to merge this to at least get the clang-format issue fixed at tip of tree. Will investigate the Bazel CI failures further.

@boomanaiden154 boomanaiden154 merged commit eb3f213 into google:main Mar 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants