work with cmake install #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-wassenberg
added
the
copybara-import
Could you help release a new version after this pr merged. so that I can create a new formula for homebrew Homebrew/homebrew-core#166881 |
|
Apologies, I did not see that this PR targets the main branch, thus our import automation failed. Would you please change it to dev? Soon after it lands in dev, we can do a release. |
ok, updated. |
jan-wassenberg
removed
the
copybara-import
jan-wassenberg
approved these changes
May 3, 2024
jan-wassenberg
added
the
copybara-import
|
Thanks! Restarted the import. |
|
Merged success to dev, could you help release a new version. Thanks. |
|
Yes, we will do one soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, gemma only works at
builddir, it better to supportcmake --installto install the build output to system directory and easy to usegemmaglobally. I made two changes:gemmaandlibgemmato be install;target_link_librariesofsentencepiecetosentencepiece-static, so that the build output is portable