Arm transform functions: generator changes #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ARM to Arm in AUTHORS and CONTRIBUTORS
Extends the NEON emitters to support fused SIMD multiply-accumulate instructions. These instructions are used in a modified BiasAdd kernel. `test_transform_correctness` is adapted to allow for minor differences between the actual and expected values resulting from re-ordering of the floating point operations.
Interleaving instructions results in a performance improvement for A57.
- Extends the generators to allow for additional declarations in generated functions. - Modifies the Requantize kernel to use FMA instructions - `test_transform_correctness` is modified to allow for small differences in implementation resulting from changes in floating point operation order.
Interleave conversion calls and use prefetching to reduce cache misses in the Requantize kernel.
This was referenced Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the generators in
metato match changes made to the optimized Arm assembly in #93.The formatting of the code that is produced by the generators doesn't match that of
meta/transform_kernels_arm_{32|64}.h, so to keep this PR simple I've not included the generated headers. #99 contains both these changes and the generated headers.Note: I've made some minor changes to
test_transform_correctnessto allow for slight differences between the actual and expected values which occur as a result of changing the order of some floating point operations.