Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependency for ChatSample #62

Merged

Conversation

treastrain
Copy link
Contributor

Description of the change

Fixed a problem in which GenerativeAIUIComponents was missing from the dependency on ChatSample and this sample app could not be built.

スクリーンショット 2023-12-14 23 54 39

Before After
スクリーンショット 2023-12-14 23 55 59 スクリーンショット 2023-12-14 23 56 46

Type of change

Bug fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Dec 14, 2023
@treastrain
Copy link
Contributor Author

Thank you!

(P.S. I enjoy watching the YouTube videos you appear in, about Firebase on the Apple platform from Japan!)

@paulb777 paulb777 merged commit 8d6462c into google-gemini:main Dec 14, 2023
8 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Dec 14, 2023
@treastrain treastrain deleted the fix-missing-import-dependencies branch December 14, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants