Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IO docs to gf180mcu_fd_io repo #34

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Move IO docs to gf180mcu_fd_io repo #34

merged 1 commit into from
Aug 2, 2022

Conversation

mohanad0mohamed
Copy link
Contributor

@mohanad0mohamed mohanad0mohamed commented Jul 25, 2022 •
edited by mithro
Loading

@mithro mithro self-requested a review July 26, 2022 02:28
@mithro
Copy link
Contributor

mithro commented Jul 28, 2022

I have started reworking this pull request in my branch at https://github.com/mithro/gf180mcu-pdk/tree/move_io

It is still missing the submodule update.

@mithro
Copy link
Contributor

mithro commented Jul 28, 2022

You should include a link to the pull request at google/globalfoundries-pdk-libs-gf180mcu_fd_io#2 in the pull request description.

@mithro mithro mentioned this pull request Jul 28, 2022
Merged
1 task
@mohanad0mohamed
Copy link
Contributor Author

mohanad0mohamed commented Jul 28, 2022 •
edited
Loading

I think the index.rst file should be updated by removing IPs/ips line from it.

@mohanad0mohamed
Copy link
Contributor Author

Updated index.rst not to give us warnings on missing files.

atorkmabrains
atorkmabrains approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this request per @mithro request.

@mithro
Copy link
Contributor

mithro commented Aug 2, 2022

@mohanad0mohamed - You didn't update the pull request description to point to the pull request on the globalfoundries-pdk-libs-gf180mcu_fd_io repository which adds the documentation there.

@mohanad0mohamed @mithro
Moving IO docs to gf180mcu_fd_io repo
e5487e6 
Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro
mithro approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reworked this pull request, if this goes green I'll merge it.

@mithro mithro merged commit db1e022 into google:main Aug 2, 2022
@mithro mithro deleted the move_io branch August 2, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atorkmabrains atorkmabrains atorkmabrains approved these changes

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the IO cell documentation into the IO cell repository
3 participants
@mohanad0mohamed @mithro @atorkmabrains