Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--max_log_size not work when larger than 4096 #497

Closed
ghostwang opened this issue Nov 20, 2019 · 1 comment · Fixed by #622
Closed

--max_log_size not work when larger than 4096 #497

ghostwang opened this issue Nov 20, 2019 · 1 comment · Fixed by #622
Assignees
Labels
Milestone

Comments

@ghostwang
Copy link

in logging.cc:
maximum of file_length_ is 0xFFFFFFFF
when --max_log_size is larger than 4096 (0xFFFFFFFF >> 20)
line 1108
if (static_cast<int>(file_length_ >> 20) >= MaxLogSize() || PidHasChanged()) {
the first condition will never satisfied.

ghostwang added a commit to ghostwang/glog that referenced this issue Nov 20, 2019
@ColdZoo
Copy link

ColdZoo commented Dec 16, 2020

Thanks for this, you save my day!
We encountered a same problem when our SRE set max_log_size to 4GB!

@sergiud sergiud added the bug label Mar 30, 2021
@sergiud sergiud self-assigned this Mar 30, 2021
@sergiud sergiud added this to the 0.5 milestone Mar 30, 2021
@sergiud sergiud mentioned this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants