Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogCleaner::IsLogFromCurrentProject incorrect when SetLogFilenameExtension #589

Closed
chjq68 opened this issue Oct 9, 2020 · 1 comment
Closed

LogCleaner::IsLogFromCurrentProject incorrect when SetLogFilenameExtension #589

chjq68 opened this issue Oct 9, 2020 · 1 comment

Comments

@chjq68
Copy link

chjq68 commented Oct 9, 2020

LogCleaner::IsLogFromCurrentProject do not consider the file extension when LogCleaner::IsLogFromCurrentProject.
aesophor added a commit to aesophor/glog that referenced this issue Oct 9, 2020
@aesophor
src/logging.cc: Make LogCleaner aware of filename extension (google#589)
431d74c 
Previously, LogCleaner::IsLogFromCurrentProject() did not consider
the custom file extension set with SetLogFilenameExtension().

This PR fixes it.

Signed-off-by: Marco Wang <m.aesophor@gmail.com>
sergiud added a commit that referenced this issue Feb 13, 2021
@sergiud
Merge pull request #592 from aesophor/fix-logcleaner-file-ext
7bba603 
src/logging.cc: Make LogCleaner aware of filename extension (#589)
@sergiud
Copy link
Collaborator

sergiud commented Feb 22, 2021

Fixed in #592.

@sergiud sergiud closed this as completed Feb 22, 2021
@sergiud sergiud mentioned this issue May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sergiud @chjq68