Add an example using glog from Bazel #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinh
approved these changes
Dec 20, 2017
iirina
reviewed
Jan 4, 2018
bazel/example/BUILD
Outdated
| size = "small", | ||
| srcs = ["main.cc"], | ||
| deps = [ | ||
| "@com_google_glog//:glog", |
There was a problem hiding this comment.
You don't need to reference the workspace name here since you are in the same workspace
There was a problem hiding this comment.
Done. This was left over from my first attempt to have the example use com_google_glog as an external repo.
Thanks for the review!
WORKSPACE
Outdated
| @@ -1,5 +1,7 @@ | |||
| workspace(name = "com_google_glog") | |||
There was a problem hiding this comment.
This is also unnecessary because you don't have multiple workspaces
iirina
approved these changes
Jan 4, 2018
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
Add an example using glog from Bazel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined with the coming job on ci.bazel.io, this should help keep the build working.
@iirina For the Bazel build.
@shinh For the example.