Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use target gflags instead of old VARIABLES #283

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

Mizux
Copy link
Contributor

@Mizux Mizux commented Jan 4, 2018

As mentioned in Use gflags ALIAS target instead of ${gflags_XXX} variables #198 do the same for the try_compile command...

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@Mizux
Copy link
Contributor Author

Mizux commented Jan 4, 2018

This patch already belongs to Google LLC, it's just that github.com WYSIWYG use my personal address...

@sergiud sergiud merged commit fb19c33 into google:master Jan 4, 2018
durswd pushed a commit to durswd/glog that referenced this pull request Sep 2, 2019
Use target gflags instead of old VARIABLES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants