-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows logging ut #331
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
76037fe
to
f39f78c
Compare
That's okay. I can squash the commits myself. |
I think this PR was unintentionally closed by merging the commit from #332 |
Would it be possible possible to get a release with this change? |
Fix windows logging ut
this is the commits from PR #93 from @artemdinaburg rebased on the current master. @artemdinaburg already signed the CLA, hope this is ok
these changes fixes the logging unittest on Windows (MSVC and MinGW)
Using CI from #330
Appveyor: https://ci.appveyor.com/project/NeroBurner/glog/build/1.0.100
Travis: https://travis-ci.org/NeroBurner/glog/builds/394146261