Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use push/pop macro when supressing warning #397

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Conversation

kwaegel
Copy link
Contributor

@kwaegel kwaegel commented Nov 28, 2018

  • Previous implementation did not correctly restore the warning state if initially disabled.

* Previous implementation did not correctly restore the warning state if initially disabled.
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@kwaegel
Copy link
Contributor Author

kwaegel commented Nov 28, 2018 via email

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@sergiud sergiud merged commit 702c533 into google:master Dec 12, 2018
@kwaegel kwaegel deleted the patch-1 branch January 18, 2019 19:03
kwaegel added a commit to kwaegel/glog that referenced this pull request Jan 22, 2019
* Same as PR google#397 , but for the `.in` file. Useful for some unusual cross-platform build environments (e.g. WSL).
shinh added a commit to shinh/glog that referenced this pull request Jan 24, 2019
windows/glog/logging.h is expected to be generated by
src/windows/preprocess.sh and should not be modified directly.
durswd pushed a commit to durswd/glog that referenced this pull request Sep 2, 2019
Use push/pop macro when supressing warning
durswd pushed a commit to durswd/glog that referenced this pull request Sep 2, 2019
* Same as PR google#397 , but for the `.in` file. Useful for some unusual cross-platform build environments (e.g. WSL).
durswd pushed a commit to durswd/glog that referenced this pull request Sep 2, 2019
windows/glog/logging.h is expected to be generated by
src/windows/preprocess.sh and should not be modified directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants