Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logmailer problem for dynamic lib use of glog. #400

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

guoyuhong
Copy link
Contributor

The problem I met.

I want to use glog in a dynamic lib (.so file), e.g. use it with Apache/Arrow.
However, if there is a global variable defined in non-empty std::string, there will be memory problems. I can catch this problem by valgrind. The following picture is the valgrind log.
image

PR change

I have changed the default value of logmailer to an empty std::string and put the default value to where FLAGS_logmailer is used when it is empty.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@guoyuhong
Copy link
Contributor Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 6, 2018
@sergiud sergiud self-assigned this Oct 2, 2020
@sergiud sergiud merged commit 4fa737b into google:master Feb 13, 2021
@sergiud sergiud mentioned this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants