Fix logmailer problem for dynamic lib use of glog. #400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem I met.
I want to use glog in a dynamic lib (.so file), e.g. use it with Apache/Arrow.
However, if there is a global variable defined in non-empty
std::string
, there will be memory problems. I can catch this problem by valgrind. The following picture is the valgrind log.PR change
I have changed the default value of
logmailer
to an emptystd::string
and put the default value to whereFLAGS_logmailer
is used when it is empty.