-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NULL to indicate uninitialized VLOG_IS_ON site. #542
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it!
…On Apr 26 2020, at 11:02 pm, googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ ***@***.***/0?redirect=https%3A%2F%2Fcla.developers.google.com%2F&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLAIndividual signers
It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data ***@***.***/1?redirect=https%3A%2F%2Fcla.developers.google.com%2Fclas&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) and verify that your email is set on your git commits ***@***.***/2?redirect=https%3A%2F%2Fhelp.github.com%2Farticles%2Fsetting-your-email-in-git%2F&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
Corporate signers
Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (http://go/cla#troubleshoot) (Public version ***@***.***/3?redirect=https%3A%2F%2Fopensource.google%2Fdocs%2Fcla%2F%23troubleshoot&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D)).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data ***@***.***/4?redirect=https%3A%2F%2Fcla.developers.google.com%2Fclas&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) and verify that your email is set on your git commits ***@***.***/5?redirect=https%3A%2F%2Fhelp.github.com%2Farticles%2Fsetting-your-email-in-git%2F&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
The email used to register you as an authorized contributor must also be attached to your GitHub account ***@***.***/6?redirect=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
ℹ️ Googlers: Go here ***@***.***/7?redirect=https%3A%2F%2Fgoto.google.com%2Fprinfo%2Fhttps%253A%252F%252Fgithub.com%252Fgoogle%252Fglog%252Fpull%252F542&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D) for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub ***@***.***/8?redirect=https%3A%2F%2Fgithub.com%2Fgoogle%2Fglog%2Fpull%2F542%23issuecomment-619684063&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe ***@***.***/9?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEA4EHVGCDE3N3IIPAWTJHDROTYUVANCNFSM4MRRGQPQ&recipient=cmVwbHkrQUVBNEVIUkZTWkZSV0VEU1c3R1VEMk40V0lXRVZFVkJOSEhDSU1JUElJQHJlcGx5LmdpdGh1Yi5jb20%3D).
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR eliminates the
kLogSiteUninitialized
variable and useNULL
to indicate uninitilizedVLOG_IS_ON
site.