Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove autoconf support #585

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Oct 1, 2020

Fixes #537.

@sergiud sergiud self-assigned this Oct 1, 2020
@google-cla google-cla bot added the cla: yes label Oct 1, 2020
@sergiud sergiud requested review from shinh, ukai and drigz October 1, 2020 09:42
@drigz
Copy link
Member

drigz commented Oct 1, 2020

README.md and INSTALL need to be updated as they refer to autoconf. For Bazel, you could add this to README.md (adapted from gflags).

Bazel

To use glog within a project which uses the Bazel build tool, add the following lines to your WORKSPACE file:

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "com_github_gflags_gflags",
    sha256 = "34af2f15cf7367513b352bdcd2493ab14ce43692d2dcd9dfc499492966c64dcf",
    strip_prefix = "gflags-2.2.2",
    urls = ["https://github.com/gflags/gflags/archive/v2.2.2.tar.gz"],
)

http_archive(
    name = "com_github_google_glog",
    sha256 = "62efeb57ff70db9ea2129a16d0f908941e355d09d6d83c9f7b18557c0a7ab59e",
    strip_prefix = "glog-d516278b1cd33cd148e8989aec488b6049a4ca0b",
    urls = ["https://github.com/google/glog/archive/d516278b1cd33cd148e8989aec488b6049a4ca0b.zip"],
)

You can then add @com_github_google_glog//:glog to the deps section of a cc_binary or cc_library rule, and #include <glog/logging.h> to include it in your source code. Here's a simple example:

cc_binary(
    name = "main",
    srcs = ["main.cc"],
    deps = ["@com_github_google_glog//:glog"],
)

@sergiud sergiud force-pushed the remove-drop-autoconf-support branch from 8320c9a to 6a86a08 Compare October 1, 2020 16:04
@sergiud
Copy link
Collaborator Author

sergiud commented Oct 1, 2020

Thanks. I also moved all the available documentation (from doc/, cmake/) to README.md to make it more accessible.

@drigz
Copy link
Member

drigz commented Oct 1, 2020

Thanks! The new README is great.

@sergiud sergiud force-pushed the remove-drop-autoconf-support branch 3 times, most recently from ba25aa3 to 42df949 Compare October 1, 2020 16:28
@sergiud sergiud marked this pull request as ready for review October 1, 2020 16:28
@sergiud sergiud force-pushed the remove-drop-autoconf-support branch 11 times, most recently from cabf761 to f06468c Compare October 2, 2020 18:16
@sergiud
Copy link
Collaborator Author

sergiud commented Oct 2, 2020

I converted the README from Markdown to reStructuredText because the latter allows to easily generate TOCs and supports Starlark syntax highlighting used by Bazel. Additionally, I moved CONTRIBUTING.md contents into README. The changes should be now final.

@sergiud sergiud force-pushed the remove-drop-autoconf-support branch from f06468c to b539557 Compare October 2, 2020 18:32
@sergiud sergiud merged commit b30a009 into google:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropping autoconf support
2 participants