cmake: allow to disable symbolize #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drigz
requested changes
Mar 31, 2021
There was a problem hiding this comment.
Hmm, I can't be certain but I guess some people might rely on symbolize. Maybe add:
linux_or_darwin_copts = wasm_copts + [
# For src/symbolize.cc.
"-DHAVE_SYMBOLIZE",
and
windows_only_copts = [
# For src/symbolize.cc.
"-DHAVE_SYMBOLIZE",
to preserve the previous functionality?
Line 56 in 7f8a48b
sergiud
force-pushed
the
cmake-allow-to-disable-symbolize
branch
from
33b7311
to
9c7cbb9
Compare
sergiud
force-pushed
the
cmake-allow-to-disable-symbolize
branch
from
9c7cbb9
to
27704b8
Compare
sergiud
force-pushed
the
cmake-allow-to-disable-symbolize
branch
from
27704b8
to
39e8358
Compare
|
@drigz I reverted the breaking changes. Bazel builds are now unaffected. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #563
@drigz
This change might break Bazel builds. Maybe there is an alternative to removal?