fixed windows builds #639
fixed windows builds #639
Conversation
sergiud
force-pushed
the
fix-windows-builds
branch
from
af30126
to
9b0e2fb
Compare
sergiud
force-pushed
the
fix-windows-builds
branch
from
11ef913
to
efc341d
Compare
| @@ -93,13 +93,13 @@ def glog_library(namespace = "google", with_gflags = 1, **kwargs): | |||
| ] | |||
|
|
|||
| windows_only_copts = [ | |||
| "-DGLOG_NO_ABBREVIATED_SEVERITIES", | |||
There was a problem hiding this comment.
This seems like it could break users. Can you add a #define to port.h instead, along the lines of the docs? https://github.com/google/glog#notes-for-windows-users
There was a problem hiding this comment.
On second thoughts, as it's in copts rather than defines, it's unlike to affect users but it would still be cleaner to use the approach in the docs IMO.
There was a problem hiding this comment.
Are you saying that the define is transitive, i.e., it is forwarded to library's consumer? Either way, CMake always defines GLOG_NO_ABBREVIATED_SEVERITIES on Windows to avoid conflicts due to ERROR:
Lines 598 to 600 in a79416b
If I recall correctly, on Windows glog without GLOG_NO_ABBREVIATED_SEVERITIES is unusable anyway once windows.h is included (which is in many cases true). Regardless, we should probably sync the approach taken by both build systems.
There was a problem hiding this comment.
defines are transitive (useful when needed in public headers) but copts are not. If CMake does it too then this LGTM, thanks!
No description provided.