-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHECK support for nullptr (fixes #341) #641
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
9bce407
to
06e72c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you also add -DHAVE_CXX11_NULLPTR_T to common_copts in bazel/glog.bzl?
@drigz In that case, |
Ah, I misread and thought that it was set to 1, sorry. Either approach is OK, in that case, but I have a slight preference for assuming a modern environment in the Bazel build: I think that people with weird environments use build systems with environment detection, and Bazel users are expecting the modern features. |
This allows CHECK_NE(foo, nullptr) to compile and produces "nullptr" for the string representation of nullptr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This allows
CHECK_NE(foo, nullptr)
to compile and produces "nullptr" for the string representation ofnullptr
.Finalizes #342
Closes #562 #341