Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHECK support for nullptr (fixes #341) #641

Merged
merged 1 commit into from Apr 12, 2021
Merged

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Apr 8, 2021

This allows CHECK_NE(foo, nullptr) to compile and produces "nullptr" for the string representation of nullptr.

Finalizes #342

Closes #562 #341

@sergiud sergiud added this to the 0.5 milestone Apr 8, 2021
@google-cla
Copy link

google-cla bot commented Apr 8, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Copy link
Member

@drigz drigz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also add -DHAVE_CXX11_NULLPTR_T to common_copts in bazel/glog.bzl?

@sergiud
Copy link
Collaborator Author

sergiud commented Apr 9, 2021

@drigz In that case, ac_cv_cxx11_nullptr_t should also be set to 1 in common_config, correct?

@drigz
Copy link
Member

drigz commented Apr 9, 2021

@drigz In that case, ac_cv_cxx11_nullptr_t should also be set to 1 in common_config, correct?

Ah, I misread and thought that it was set to 1, sorry. Either approach is OK, in that case, but I have a slight preference for assuming a modern environment in the Bazel build: I think that people with weird environments use build systems with environment detection, and Bazel users are expecting the modern features.

This allows CHECK_NE(foo, nullptr) to compile and produces "nullptr" for the
string representation of nullptr.
Copy link
Member

@drigz drigz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants