-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake support #7
Conversation
c4ccc38
to
82823b0
Compare
on ubuntu/trusty at commit 82823b0 $ ./configure && make |
same error at commit 0caa067 |
It's commit ab0a2da that causes the problem. The |
Actually, |
c89b512
to
0732986
Compare
84dc748
to
44a22f8
Compare
still failing with autoconf at commit 44a22f8 $ ./configure && make |
I'm not seeing this error on Arch Linux. |
I can reproduce the problem on Ubuntu 12.04. Will look into it. |
Can you please check again? |
Will this be approved and merged? This is definitely something I'm looking for. |
Looks promising; also interested in this. |
37841fa
to
8453b08
Compare
+1 |
1 similar comment
+1 |
@hausdorff glog support cmake now :-) |
Good work! |
When will this be included in a release? |
Add CMake support. closes google#4
This series of patches adds CMake support to glog and fixes several compilation issues.
My primary goal was to be able to compile glog on Windows using Visual Studio without any hassle. The modifications have been tested using VC 8.0 through VC 14.0 CTP 6, cygwin gcc 4.9.2, Intel C++ Compiler 15.0, Apple Clang, and on Arch Linux using gcc 4.9.2 and clang 3.6 (both static and shared builds).
CMakeLists.txt
also generates config files, which allow to use glog in CMake projects easily:To run the unit tests, execute:
make test
when using the Makefiles generator.