Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test CLI with vectors from specification. #83

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Test CLI with vectors from specification. #83

merged 1 commit into from
Feb 19, 2021

Conversation

burgerdev
Copy link
Collaborator

Fixes #50.

vvidic
vvidic approved these changes Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@vvidic vvidic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, perhaps only use hex values (\xHH) in printf instead of octal?

@burgerdev
Copy link
Collaborator Author

Thanks for the review! Afaiu octal is the only portable binary encoding for printf: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/printf.html#tag_20_94_13.

@vvidic
Copy link
Collaborator

vvidic commented Feb 18, 2021

Yes, I see now that BSD for example does not have hex in printf(1).

@copybara-service copybara-service bot merged commit 07bbbdb into google:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvidic vvidic vvidic approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI should be tested according to specification
3 participants
@burgerdev @vvidic @googlebot