Remove overly specific features that don't belong to the GLOME login protocol #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is too specific to be included in a general purpose library, removing it in an attempt to simplify the code base. Lockdown mode should ideally be delegated to pam_nologin.so, or alternatively tested by a preflight check in the binary linking GLOME login.
Rebooting is best handled outside of the system's login logic. If it's desired that logging in with a special username triggers a reboot, this can be set up with a combination of PAM module and user shell. On systems where this is not desired, having the option may lead to disruptive misconfigurations.
burgerdev
changed the title
l9i
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes two features that are better handled outside the glome-login protocol: handling reboots and handling system lockdown. These features complicate the codebase and are imho not useful for the general public. Interested parties can implement similar features by wrapping the login library.