Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create gNOI Reset Client #97

Closed
loriscn12 opened this issue Jun 30, 2020 · 0 comments · Fixed by #102, #104 or #121
Closed

Create gNOI Reset Client #97

loriscn12 opened this issue Jun 30, 2020 · 0 comments · Fixed by #102, #104 or #121
Assignees
@Jared-Mullin
Labels
enhancement gnoi
Milestone
gNOI Reset Testin...

Comments

@loriscn12
Copy link
Contributor

This issue consists of building client for testing the gNOI Reset service implementation.

As part of this client implementation, the following gNOI Reset service operations will be tested:

Start a Factory Reset
@Jared-Mullin Jared-Mullin self-assigned this Jun 30, 2020
Jared-Mullin added a commit to Jared-Mullin/gnxi that referenced this issue Jul 1, 2020
@Jared-Mullin
Initial client for gNOI factory_reset (Issue google#97), checks for e…
92aa71e 
…rrors in

gRPC response and invokes Start service
@Jared-Mullin Jared-Mullin mentioned this issue Jul 1, 2020
Merged
samribeiro pushed a commit that referenced this issue Jul 1, 2020
@Jared-Mullin
gNOI Client (#102)
e1b3567 
* Initial client for gNOI factory_reset (Issue #97), checks for errors in
gRPC response and invokes Start service

* Adjust comment

* Removed unnecessary log of response

* Added Copyright and License text

* Fixed year in license text and included pb to pass Travis

* Changed impossible to unsupported

* Assuming all errors may be triggered simultaneously, now reporting all

* Created New ResetError struct which facilitates multiple error messages
Altered tests to compare error response

* Added comments to ResetError

* Updated Comment and removed log

* Included ResetSuccess test, used continue to avoid segfail

* Removed log from client_test

* Changed CheckResponse() to return *ResetError
@Jared-Mullin Jared-Mullin mentioned this issue Jul 2, 2020
Merged
This was linked to pull requests Jul 2, 2020
gNOI Client #102
Merged
gNOI Reset Client Binary and README #104
Merged
@loriscn12 loriscn12 linked a pull request Jul 7, 2020 that will close this issue
Fixed type error, ResetTarget returns a *ResetError #121
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jared-Mullin Jared-Mullin

Labels
enhancement gnoi
Projects
None yet
Milestone
gNOI Reset Testing Framework
2 participants
@Jared-Mullin @loriscn12