Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: gitattributes: ignore eol=lf to png and testdata #3239

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Mar 7, 2023

all: gitattributes: ignore eol=lf to png and testdata.

Currently, have diffs even if clean fetching this repository.

$ git clone https://github.com/google/go-cloud gocloud.dev
$ cd gocloud.dev
$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   internal/docs/img/user-facing-type-no-driver.png
	modified:   internal/docs/img/user-facing-type.png
	modified:   internal/website/content/concepts/structure/portable-type-no-driver.png
	modified:   internal/website/content/concepts/structure/portable-type.png
	modified:   internal/website/static/favicon-32x32.png
	modified:   internal/website/static/gh.png
	modified:   internal/website/static/go-cdk-logo-gopherblue-small.png
	modified:   internal/website/static/go-cdk-logo-gopherblue.png
	modified:   internal/website/static/go-cdk-logo-white.png
	modified:   internal/website/static/placeholder-logo.png
	modified:   samples/guestbook/blobs/aws.png
	modified:   samples/guestbook/blobs/azure.png
	modified:   samples/guestbook/blobs/gcp.png
	modified:   samples/order/testdata/cat1
	modified:   samples/tutorial/gopher.png

no changes added to commit (use "git add" and/or "git commit -a")

$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/zchee/.cache/go/go-build"
GOENV="/Users/zchee/.config/go/env"
GOEXE=""
GOEXPERIMENT="arenas,cgocheck2,coverageredesign,heapminimum512kib,pagetrace"
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/zchee/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/zchee/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="devel go1.21-ebc2aaae24 Mon Mar 6 21:18:42 2023 +0000 X:heapminimum512kib,arenas,pagetrace,cgocheck2"
GCCGO="gccgo"
GOAMD64="v4"
AR="ar"
CC="/Applications/Xcode-14.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang"
CXX="/Applications/Xcode-14.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++"
CGO_ENABLED="1"
GOMOD="/Users/zchee/go/src/gocloud.dev/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/fb/04yhz5d96yg03xkcfzpjhjx40000gp/T/go-build1109073516=/tmp/go-build -gno-record-gcc-switches -fno-common"

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@zchee
Copy link
Contributor Author

zchee commented Mar 7, 2023

/cc @vangent

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #3239 (be41e58) into master (48680fe) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3239   +/-   ##
=======================================
  Coverage   77.34%   77.35%           
=======================================
  Files         103      103           
  Lines       13548    13548           
=======================================
+ Hits        10479    10480    +1     
+ Misses       2340     2339    -1     
  Partials      729      729           
Impacted Files Coverage Δ
internal/retry/retry.go 88.23% <0.00%> (-11.77%) ⬇️
blob/s3blob/s3blob.go 89.71% <0.00%> (+0.27%) ⬆️
runtimevar/awsparamstore/awsparamstore.go 89.02% <0.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zchee
Copy link
Contributor Author

zchee commented Mar 29, 2023

@vangent gentle ping.

@vangent vangent merged commit aeb26ed into google:master Mar 29, 2023
@zchee zchee deleted the gitattributes-text branch March 29, 2023 19:21
ybourgery pushed a commit to Simprints/go-cloud that referenced this pull request Jun 17, 2024
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants