Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to configure max_send_batch_size in GCP pubsub. #3257

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

bianpengyuan
Copy link
Contributor

Same as max_recv_batch_size, make it possible to customize max_send_batch_size at GCP pubsub package.

@google-cla
Copy link

google-cla bot commented Jun 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bianpengyuan
Copy link
Contributor Author

Hi @vangent could you please take a look? Thank you!

@bianpengyuan
Copy link
Contributor Author

@vangent gentle ping, could you please take a look? Thank you!

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #3257 (47fa19e) into master (28b1328) will increase coverage by 0.04%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master    #3257      +/-   ##
==========================================
+ Coverage   77.37%   77.41%   +0.04%     
==========================================
  Files         103      103              
  Lines       13544    13554      +10     
==========================================
+ Hits        10479    10493      +14     
+ Misses       2338     2335       -3     
+ Partials      727      726       -1     
Impacted Files Coverage Δ
pubsub/gcppubsub/gcppubsub.go 80.68% <78.57%> (-0.03%) ⬇️

... and 3 files with indirect coverage changes

@vangent vangent merged commit 1db413f into google:master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants