Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/azblob: fix use of SAS token in service URL #3284

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Jul 21, 2023

Fixes #3283.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #3284 (3a235fd) into master (8f12933) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #3284      +/-   ##
==========================================
- Coverage   77.47%   77.45%   -0.03%     
==========================================
  Files         104      104              
  Lines       13721    13723       +2     
==========================================
- Hits        10631    10629       -2     
- Misses       2353     2356       +3     
- Partials      737      738       +1     
Impacted Files Coverage Δ
blob/azureblob/azureblob.go 86.91% <33.33%> (-0.37%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azureblob Bucket.Exists() fails to work if auth uses SAS token
1 participant