Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support foreign/restricted layers #207

Closed
dekkagaijin opened this issue Jun 6, 2018 · 5 comments · Fixed by #506
Closed

Support foreign/restricted layers #207

dekkagaijin opened this issue Jun 6, 2018 · 5 comments · Fixed by #506

Comments

@dekkagaijin
Copy link
Contributor

This is mostly an issue when naively attempting to pull layers.

Docker V2 Schema2 media type: application/vnd.docker.image.rootfs.foreign.diff.tar.gzip

OCI NonDistributable: https://github.com/opencontainers/image-spec/blob/master/specs-go/v1/mediatype.go

Tagging @jonjohnsonjr for others that I missed

@dekkagaijin
Copy link
Contributor Author

I'll be doing this for the python lib, and will do the work for ggcr, as well, if it isn't picked up beforehand.

@genevieve
Copy link

Hey @jonjohnsonjr! Are you looking for someone to make a PR for this functionality? Are you interested in this library supporting this functionality?

@dekkagaijin
Copy link
Contributor Author

@genevieve all the love this lib gets is a good thing, most likely.

I only updated the Python lib to support remote -> remote registry pushes before leaving the team, and don't know if it's been updated internally or externally to support local pulls or pushes.

@jonjohnsonjr
Copy link
Collaborator

@genevieve yeah we're definitely interested in supporting this, I just haven't found the time to add it.

At one point I started working on it but got distracted: master...jonjohnsonjr:foreign

I'm not sure how far behind that branch is -- rebasing might be harder than starting from scratch :)

@genevieve
Copy link

@dekkagaijin @jonjohnsonjr Thank you both for your quick responses! I'm going to try working on it now and I'll get back to you if I find myself in over my head!

christarazi added a commit to cloudfoundry/bosh-stemcells-ci that referenced this issue Jun 17, 2019
There seems to be a bug / missing feature for the registry-image
resource where it will fail to run if the image contains foreign layers.
I do not know what this means to us and why our image contains foreign
layers, but we will revert back to the original docker-image resource
for now.

There was an investigation that the BOSH Windows team did into this and
they have submitted a feature request to the upstream library which
handles the layers.

Links:
https://gist.github.com/genevieve/135474773f78c39a38717ca49083dda1
concourse/registry-image-resource#33
google/go-containerregistry#207
This was referenced Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants