Add mock server outline and test #19
Conversation
| } | ||
| writeProtocolMessage(rw.Writer, response) | ||
| log.Printf("Response sent\n\t%#v\n", response) | ||
| rw.Flush() |
There was a problem hiding this comment.
I was looking for this line :)
In general, I don't see a reason to buffer the writer here. The code seems to be using bufio.ReadWriter only to bunch together the reader and the writer, but the writer doesn't have to be buffered.
The code can go in as is for now, but please add a TODO/issue to refactor this. I would suggest making server a type with methods, and the writer and bufio.Reader to be struct fields in the type. The methods can then simply access them.
Then you also wouldn't have to pass these readers/writers around to handlers, dispatchers, etc.
| @@ -105,3 +106,21 @@ func readContentLengthHeader(r *bufio.Reader) (contentLength int, err error) { | |||
| } | |||
| return strconv.Atoi(headerAndLength[1]) | |||
| } | |||
|
|
|||
| // WriteProtocolMessage encodes message and writes it to w. | |||
| func WriteProtocolMessage(w io.Writer, message Message) error { | |||
There was a problem hiding this comment.
Nit: now that these higher level functions are in io.go, add an issue to consider making the other functions unexported. It's unlikely that we'll want clients to use them directly, and for tests it doesn't matter (because they're in the same package). It's always possible to export a new function w/o breaking the API, whereas the reverse is not possible. So "hidden by default" is safer
No description provided.