Address review feedback to eliminate race condition

Author: gmlewis

github/github.go

@@ -192,7 +192,8 @@ type service struct {
 func (c *Client) Client() *http.Client {
 	c.clientMu.Lock()
 	defer c.clientMu.Unlock()
-	return c.client
+	clientCopy := *c.client
+	return &clientCopy
 }
 
 // ListOptions specifies the optional parameters to various List methods that

github/github_test.go

@@ -235,8 +235,8 @@ func TestNewClient(t *testing.T) {
 func TestClient(t *testing.T) {
 	c := NewClient(nil)
 	c2 := c.Client()
-	if c.client != c2 {
-		t.Error("Client returned different http.Client, but should be the same.")
+	if c.client == c2 {
+		t.Error("Client returned same http.Client, but should be different")
 	}
 }