Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to documentation #1565

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Added link to documentation #1565

merged 2 commits into from
Jun 21, 2020

Conversation

reetuparna
Copy link
Contributor

Fixes #1561

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 21, 2020
@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #1565 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1565   +/-   ##
=======================================
  Coverage   67.90%   67.90%           
=======================================
  Files          95       95           
  Lines        8722     8722           
=======================================
  Hits         5923     5923           
  Misses       1892     1892           
  Partials      907      907           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd210e...2606196. Read the comment docs.

README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -224,6 +225,7 @@ For complete usage of go-github, see the full [package docs][].
[package docs]: https://godoc.org/github.com/google/go-github/github
[GraphQL API v4]: https://developer.github.com/v4/
[shurcooL/githubv4]: https://github.com/shurcooL/githubv4
[documentation]: https://pkg.go.dev/github.com/google/go-github/v32/github?tab=doc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this line and change the URL above on line 225 to this one:

[package docs]: https://pkg.go.dev/github.com/google/go-github/v32/github

Let's also get rid of the "?tab=doc" because that is added by the backend and may change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @reetuparna !
LGTM.
Merging.

@gmlewis gmlewis merged commit be9fac6 into google:master Jun 21, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to your documentation is missing
3 participants