Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HeadSHA parameter from UpdateCheckRunOptions #1658

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Remove HeadSHA parameter from UpdateCheckRunOptions #1658

merged 2 commits into from
Dec 2, 2020

Conversation

ishanupadhyay
Copy link
Contributor

@ishanupadhyay ishanupadhyay commented Dec 2, 2020 •
edited by gmlewis
Loading

This PR is regarding issue 1652. head_sha is no longer supported as a parameter in case of updating a check run. Therefore it is being removed from type UpdateCheckRunOptions in this PR.

Fixes #1652.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020 •
edited
Loading

Codecov Report

Merging #1658 (7ef0c2a) into master (b02f47a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1658   +/-   ##
=======================================
  Coverage   70.01%   70.01%           
=======================================
  Files          97       97           
  Lines        6340     6340           
=======================================
  Hits         4439     4439           
  Misses        985      985           
  Partials      916      916
Impacted Files Coverage Δ
github/checks.go 54.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b02f47a...7ef0c2a. Read the comment docs.

@ishanupadhyay
Copy link
Contributor Author

@gmlewis can you please review this PR ?

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Dec 2, 2020
@gmlewis gmlewis changed the title removed head_sha parameter in update check run Remove HeadSHA parameter from UpdateCheckRunOptions Dec 2, 2020
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 2, 2020

Note that this PR is a breaking API change, so I've added the label to keep track.

gmlewis
gmlewis approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ishanupadhyay!
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp December 2, 2020 15:29
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 2, 2020

@erikkn - it would be nice to get all breaking changes into the next major release (v33.0.0) so that we don't have to bump the major version more often than necessary. If you feel like reviewing this PR, that would be greatly appreciated.

erikkn
erikkn approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@erikkn erikkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are aware of the breaking API change, so LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 2, 2020

Thank you, @erikkn !
Merging.

@gmlewis gmlewis merged commit bdb4266 into google:master Dec 2, 2020
@KyleJu KyleJu mentioned this pull request Feb 18, 2021
Closed
@axdotl axdotl mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikkn erikkn erikkn approved these changes

@gmlewis gmlewis gmlewis approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Check Run HeadSHA
3 participants
@ishanupadhyay @gmlewis @erikkn