Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WorkflowRun and Workflow to DeploymentEvent #2755

Merged

Conversation

soniachikh
Copy link
Contributor

No description provided.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @soniachikh .
Please run go generate ./... as described in CONTRIBUTING.md and push the results to this PR.

github/event_types.go Outdated Show resolved Hide resolved
@gmlewis gmlewis changed the title add workflow run and workflow to deployment event Add WorkflowRun and Workflow to DeploymentEvent Aug 15, 2023
github/event_types.go Outdated Show resolved Hide resolved
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 15, 2023

@google-ospo-team - here is another PR where the googlebot has failed to comment. Please address.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2755 (66d940c) into master (0c10d67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2755   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         139      139           
  Lines       12357    12357           
=======================================
  Hits        12119    12119           
  Misses        162      162           
  Partials       76       76           
Files Changed Coverage Δ
github/event_types.go 100.00% <ø> (ø)

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @soniachikh !
LGTM.

Awaiting response from @google-ospo-team before merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 15, 2023

Ah! We now have the cla/google check - @soniachikh - please follow the instructions to sign the Google CLA and then we can merge this PR. Thank you!

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 15, 2023

Thank you, @soniachikh and @google-ospo-team !
CLA has been cleared.
Merging.

@gmlewis gmlewis merged commit d00a78f into google:master Aug 15, 2023
9 checks passed
@google-admin
Copy link
Member

FYI - there is an ongoing issue with GitHub webhooks (https://www.githubstatus.com/) that is likely causing the delays in the CLA check running.

@stockmaj
Copy link

@gmlewis is there a plan to release soon? I see it's been a while.

@stockmaj stockmaj deleted the add-workflow-workflowrun-to-deployment-event branch August 16, 2023 15:38
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 16, 2023

@gmlewis is there a plan to release soon? I see it's been a while.

Yes, you are right, and we've had a lot of activity in the repo since the last release.
It would be nice to get #2865 and #2869 reviewed and merged... and maybe even #2876 .
If you could assist by reviewing the outstanding PRs, that would help tremendously.
Thank you!

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 16, 2023

@stockmaj - here is the new release:
https://github.com/google/go-github/releases/tag/v54.0.0

@stockmaj
Copy link

Thank you.

gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants