Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of +:, in, in super #87

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Conversation

sbarzowski
Copy link
Collaborator

Also profiling

@sbarzowski sbarzowski changed the title Support of +:, in super Support of +:, in, in super Sep 27, 2017
@sbarzowski
Copy link
Collaborator Author

@sparkprime @lwander

It's a bit different from what happens in C++:

  • For in and in super, C++ retrieves all fields and checks if any matches the right one. Here we just do a regular lookup for a field and then check if it's nil.
  • +: is not desugared to a regular field. This way we avoid multiple evaluations of the key and object field lookups.

@coveralls
Copy link

coveralls commented Sep 27, 2017

Coverage Status

Coverage increased (+0.07%) to 83.091% when pulling 3ef2f49 on sbarzowski:desugarer into 850575c on google:master.

Copy link
Contributor

@sparkprime sparkprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping me for merge

@sbarzowski
Copy link
Collaborator Author

@sparkprime ping

@coveralls
Copy link

coveralls commented Sep 28, 2017

Coverage Status

Coverage increased (+0.07%) to 83.297% when pulling ba9694d on sbarzowski:desugarer into 93bcf64 on google:master.

@sparkprime sparkprime merged commit 0c86c9e into google:master Sep 29, 2017
@sbarzowski sbarzowski mentioned this pull request Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants