-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added first version of CSP plugin. #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kele
requested changes
Aug 18, 2020
empijei
suggested changes
Aug 18, 2020
kele
reviewed
Aug 18, 2020
I implemented the feedback I got from Rob during the sync. PTAL |
kele
reviewed
Aug 18, 2020
kele
reviewed
Aug 18, 2020
kele
requested changes
Aug 19, 2020
kele
requested changes
Aug 20, 2020
kele
reviewed
Aug 20, 2020
It supports creating custom CSP policies. The interceptor contains two policies, one for enforcement and one for reporting. A default policy based on https://csp.withgoogle.com/docs/strict-csp.html is also provided.
…ing a strict nonce-based CSP and a framing CSP.
mattiasgrenfeldt
force-pushed
the
grenfeldt-csp-plugin-first-version
branch
from
August 20, 2020 12:34
b73021b
to
df8bc5a
Compare
Rebasing on top of master so that tests don't fail anymore |
maramihali
suggested changes
Aug 24, 2020
empijei
suggested changes
Aug 24, 2020
…eaders close to eachother.
…ion instead of each time Before is called.
maramihali
suggested changes
Aug 26, 2020
empijei
reviewed
Aug 26, 2020
…mic as a fall back mechanism
maramihali
approved these changes
Aug 26, 2020
empijei
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It supports creating custom CSP policies. The interceptor contains two policies, one for enforcement and one for reporting. A default policy based on https://csp.withgoogle.com/docs/strict-csp.html is also provided.
Fixes #74