This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Add fuzzing for time.Time #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var sec, nsec int64 | ||
| c.Fuzz(&sec) | ||
| c.Fuzz(&nsec) | ||
| *t = time.Unix(sec, nsec) |
There was a problem hiding this comment.
I noticed that time.Time has a time zone. Might make sense to randomize that, too?
There was a problem hiding this comment.
@lavalamp Agree it would be nice, but I think it will take a little more thought on how to do safely, since not all time zones may be loaded on all systems. See:
http://golang.org/pkg/time/#LoadLocation
http://golang.org/src/pkg/time/zoneinfo.go?s=7499:7548#L263
There was a problem hiding this comment.
Good point. That is pretty ugly.
|
LGTM - just one comment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #6