Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bzlmod module file #4118

Closed
wants to merge 6 commits into from
Closed

Add bzlmod module file #4118

wants to merge 6 commits into from

Conversation

hanneskaeufler
Copy link

@hanneskaeufler hanneskaeufler commented Jan 6, 2023

Motivation:
bazelbuild/bazel-central-registry#124

Open questions:

  • Is the googletest project willing to maintain the bzlmod file?

module(
name = "googletest",
compatibility_level = 1,
version = "0.0.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order not to have to maintain a version number multiple times (or at all), it seems to be a somewhat often used practice to have 0.0.0 here and just increment the version number in the bazel central registry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version attribute is optional - maybe leave it out, instead of using 0.0.0

@hanneskaeufler hanneskaeufler changed the title Hk bzlmod Add bzlmod module file Jan 9, 2023
@hanneskaeufler hanneskaeufler marked this pull request as ready for review January 9, 2023 18:54
@derekmauro derekmauro self-assigned this Jan 9, 2023
@hanneskaeufler
Copy link
Author

@derekmauro Anything I can do to move this forward? thanks!

@Vertexwahn
Copy link
Contributor

@derekmauro Can we bring this forward?

@Vertexwahn
Copy link
Contributor

@derekmauro Please review!

Copy link
Member

@derekmauro derekmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure how this is supposed to work.

We prefer to live at head. This means, for example, that sometimes we might use a feature in the latest head version of Abseil that isn't part of any release. How is bzlmod supposed to deal with this?

@Vertexwahn
Copy link
Contributor

@derekmauro Good point! There is archive_override to override a specific version with a new one: #4368

@hanneskaeufler
Copy link
Author

Closing in favor of #4368, thanks for picking this up Vertexwahn!

@hanneskaeufler hanneskaeufler deleted the hk-bzlmod branch September 11, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants