-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bzlmod module file #4118
Add bzlmod module file #4118
Conversation
module( | ||
name = "googletest", | ||
compatibility_level = 1, | ||
version = "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order not to have to maintain a version number multiple times (or at all), it seems to be a somewhat often used practice to have 0.0.0
here and just increment the version number in the bazel central registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version attribute is optional - maybe leave it out, instead of using 0.0.0
@derekmauro Anything I can do to move this forward? thanks! |
@derekmauro Can we bring this forward? |
@derekmauro Please review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure how this is supposed to work.
We prefer to live at head. This means, for example, that sometimes we might use a feature in the latest head version of Abseil that isn't part of any release. How is bzlmod supposed to deal with this?
@derekmauro Good point! There is |
Closing in favor of #4368, thanks for picking this up Vertexwahn! |
Motivation:
bazelbuild/bazel-central-registry#124
Open questions: