Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goprocess: replace go-ps with gopsutil #187

Merged
merged 3 commits into from
Nov 25, 2022
Merged

goprocess: replace go-ps with gopsutil #187

merged 3 commits into from
Nov 25, 2022

Conversation

zhsj
Copy link
Contributor

@zhsj zhsj commented Nov 22, 2022

The keybase's fork of go-ps seems abandoned, and gopsutil is already introduced with same functionalities.

tklauser
tklauser reviewed Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Changes look good to me apart from one inline comment about making tests Linux-specific.

goprocess/goprocess_linux_test.go Outdated Show resolved Hide resolved
@zhsj
goprocess: replace go-ps with gopsutil
c019eae 
The keybase's fork of go-ps seems abandoned, and gopsutil is already
introduced with same functionalities.
tklauser
tklauser approved these changes Nov 25, 2022
View reviewed changes
goprocess/goprocess_test.go Outdated Show resolved Hide resolved
@tklauser tklauser merged commit eebecad into google:master Nov 25, 2022
@tklauser
Copy link
Collaborator

Thanks @zhsj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhsj @tklauser