-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix process command crash when provided with no args #219
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Use cobra.MinimumNArgs to require at least one argument and handle errors in processing the arguments. Improve the use help string.
2576f1a
to
0d37745
Compare
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/google/gops](https://togithub.com/google/gops) | require | patch | `v0.3.27` -> `v0.3.28` | --- ### Release Notes <details> <summary>google/gops (github.com/google/gops)</summary> ### [`v0.3.28`](https://togithub.com/google/gops/releases/tag/v0.3.28) [Compare Source](https://togithub.com/google/gops/compare/v0.3.27...v0.3.28) #### What's Changed - build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.1 to 3.23.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/204](https://togithub.com/google/gops/pull/204) - build(deps): bump golang.org/x/sys from 0.5.0 to 0.6.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/205](https://togithub.com/google/gops/pull/205) - build(deps): bump github.com/xlab/treeprint from 1.1.0 to 1.2.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/206](https://togithub.com/google/gops/pull/206) - build(deps): bump actions/setup-go from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/207](https://togithub.com/google/gops/pull/207) - build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.2 to 3.23.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/208](https://togithub.com/google/gops/pull/208) - build(deps): bump golang.org/x/sys from 0.6.0 to 0.7.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/209](https://togithub.com/google/gops/pull/209) - build(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/210](https://togithub.com/google/gops/pull/210) - build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.3 to 3.23.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/211](https://togithub.com/google/gops/pull/211) - build(deps): bump golang.org/x/sys from 0.7.0 to 0.8.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/212](https://togithub.com/google/gops/pull/212) - build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.4 to 3.23.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/214](https://togithub.com/google/gops/pull/214) - build(deps): bump golang.org/x/sys from 0.8.0 to 0.9.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/215](https://togithub.com/google/gops/pull/215) - build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.5 to 3.23.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/220](https://togithub.com/google/gops/pull/220) - build(deps): bump golang.org/x/sys from 0.10.0 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/gops/pull/221](https://togithub.com/google/gops/pull/221) - Fix process command crash when provided with no args by [@​mtardy](https://togithub.com/mtardy) in [https://github.com/google/gops/pull/219](https://togithub.com/google/gops/pull/219) #### New Contributors - [@​mtardy](https://togithub.com/mtardy) made their first contribution in [https://github.com/google/gops/pull/219](https://togithub.com/google/gops/pull/219) **Full Changelog**: google/gops@v0.3.27...v0.3.28 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
Use cobra.MinimumNArgs to require at least one argument and handle errors in processing the arguments. Improve the use help string.