Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process command crash when provided with no args #219

Merged
merged 1 commit into from Aug 9, 2023

Conversation

mtardy
Copy link
Contributor

@mtardy mtardy commented Jul 24, 2023

Use cobra.MinimumNArgs to require at least one argument and handle errors in processing the arguments. Improve the use help string.

@google-cla
Copy link

google-cla bot commented Jul 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tklauser tklauser enabled auto-merge (rebase) August 9, 2023 09:30
@tklauser tklauser disabled auto-merge August 9, 2023 09:34
Use cobra.MinimumNArgs to require at least one argument and handle
errors in processing the arguments. Improve the use help string.
@tklauser tklauser merged commit ac7253a into google:master Aug 9, 2023
10 checks passed
@mtardy mtardy deleted the fix-process-crash branch August 9, 2023 09:51
nono added a commit to cozy/cozy-stack that referenced this pull request Aug 21, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/google/gops](https://togithub.com/google/gops) | require |
patch | `v0.3.27` -> `v0.3.28` |

---

### Release Notes

<details>
<summary>google/gops (github.com/google/gops)</summary>

### [`v0.3.28`](https://togithub.com/google/gops/releases/tag/v0.3.28)

[Compare
Source](https://togithub.com/google/gops/compare/v0.3.27...v0.3.28)

#### What's Changed

- build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.1 to 3.23.2
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#204
- build(deps): bump golang.org/x/sys from 0.5.0 to 0.6.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#205
- build(deps): bump github.com/xlab/treeprint from 1.1.0 to 1.2.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#206
- build(deps): bump actions/setup-go from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#207
- build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.2 to 3.23.3
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#208
- build(deps): bump golang.org/x/sys from 0.6.0 to 0.7.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#209
- build(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#210
- build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.3 to 3.23.4
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#211
- build(deps): bump golang.org/x/sys from 0.7.0 to 0.8.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#212
- build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.4 to 3.23.5
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#214
- build(deps): bump golang.org/x/sys from 0.8.0 to 0.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#215
- build(deps): bump github.com/shirou/gopsutil/v3 from 3.23.5 to 3.23.7
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#220
- build(deps): bump golang.org/x/sys from 0.10.0 to 0.11.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[google/gops#221
- Fix process command crash when provided with no args by
[@&#8203;mtardy](https://togithub.com/mtardy) in
[google/gops#219

#### New Contributors

- [@&#8203;mtardy](https://togithub.com/mtardy) made their first
contribution in
[google/gops#219

**Full Changelog**:
google/gops@v0.3.27...v0.3.28

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cozy/cozy-stack).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants