Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address breaking changes from xlab/treeprint #84

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

shihanng
Copy link
Contributor

Hi, in our internal testing tool we found that a PR of xlab/treeprint (xlab/treeprint#6) which was merged might break gops in the future. The PR removed treeprint.EdgeTypeStart. To set the root node, we can now use SetValue(value Value) instead.

In this commit,

dep ensure -update github.com/xlab/treeprint

was executed to update the library and then fix is applied.

A PR of xlab/treeprint (xlab/treeprint#6)
which was merged might break gops in the future.
The PR removed treeprint.EdgeTypeStart. To set the root node,
we can now use SetValue(value Value) instead.

In this commit,

    dep ensure -update github.com/xlab/treeprint

was executed to update the library and then fix is applied.
@rakyll
Copy link
Member

rakyll commented Jul 11, 2018

Thanks!

@rakyll rakyll merged commit e4108e7 into google:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants