Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Health] Set up linting #58

Closed
dhvogel opened this issue Jun 6, 2019 · 3 comments · Fixed by #65
Closed

[Code Health] Set up linting #58

dhvogel opened this issue Jun 6, 2019 · 3 comments · Fixed by #65
Assignees

Comments

@dhvogel
Copy link
Contributor

dhvogel commented Jun 6, 2019

People who contribute to this project may have differing code style norms. We should add linting rules to enforce consistent norms around code aesthetics. Ideally, these linting checks would be run on presubmit (PR opening) by some continuous integration tool.

eslint-plugin-react looks like a good option: https://github.com/yannickcr/eslint-plugin-react

@gino-m
Copy link
Collaborator

gino-m commented Jun 6, 2019

+1. Is this something you mind be interested in helping set up?

@gino-m
Copy link
Collaborator

gino-m commented Jun 13, 2019

I noticed some files are using tabs and others spaces. Can we update our linter to enforce two-space indent? @gyarill FYI.

Or even better, would https://github.com/google/eslint-config-google work with JSX?

@dhvogel
Copy link
Contributor Author

dhvogel commented Jun 13, 2019

Added google standard config in #65

os-micmec added a commit that referenced this issue Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants